Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter out the Tombstones folder from quick launch (#856) #967

Closed
wants to merge 1 commit into from

Conversation

dremin
Copy link
Owner

@dremin dremin commented Dec 1, 2024

No description provided.

@xoascf
Copy link
Collaborator

xoascf commented Dec 1, 2024

It doesn't just hide the "Tombstones" folder, it only does that for hidden items; I just saw that folder is set to hidden in its properties.

@dremin
Copy link
Owner Author

dremin commented Dec 1, 2024

It doesn't just hide the folders in that path, I remember it only does that for hidden items, maybe the "Tombstones" folder is set to hidden in its properties.

I don't quite understand, are you seeing this change hide items unintentionally?

@xoascf
Copy link
Collaborator

xoascf commented Dec 1, 2024

It doesn't just hide the folders in that path, I remember it only does that for hidden items, maybe the "Tombstones" folder is set to hidden in its properties.

I don't quite understand, are you seeing this change hide items unintentionally?

If an item in a path selected for Quick Launch has the "Hidden" property set, it will not be displayed:
prophidden

@dremin
Copy link
Owner Author

dremin commented Dec 1, 2024

It doesn't just hide the folders in that path, I remember it only does that for hidden items, maybe the "Tombstones" folder is set to hidden in its properties.

I don't quite understand, are you seeing this change hide items unintentionally?

If an item in a path selected for Quick Launch has the "Hidden" property set, it will not be displayed: prophidden

Oh! Yeah, that is expected and RetroBar behaves the same way. For some reason it seems like when the system creates the Tombstones folder, it is not marked as hidden, so it still shows in RetroBar.

@xoascf
Copy link
Collaborator

xoascf commented Dec 1, 2024

A bit hacky, at least here it was hidden by default, I thought it would be better to advise the user to "hide" this folder? I guess that could work as a workaround, or the classic %AppData%\Microsoft\Internet Explorer\Quick Launch could be used by default instead? (if not someone really crazy creates a folder with a path ending in \Microsoft\Internet Explorer\Quick Launch\User Pinned\TaskBar\Tombstones and sees that his folder is hidden 😆).

@dremin
Copy link
Owner Author

dremin commented Dec 1, 2024

A bit hacky, at least here it was hidden by default, I thought it would be better to advise the user to "hide" this folder? I guess that could work as a workaround, or the classic %AppData%\Microsoft\Internet Explorer\Quick Launch could be used by default instead? (if not someone really crazy creates a folder with a path ending in \Microsoft\Internet Explorer\Quick Launch\User Pinned\TaskBar\Tombstones and sees that his folder is hidden 😆).

Hm, it's definitely shown up for me. I believe that even if the system is hiding the folder, RetroBar may still show it because we don't get notifications when the hidden attribute changes. I'll change this to an exact path match at least.

@dremin
Copy link
Owner Author

dremin commented Dec 2, 2024

I am fixing the hidden file handling in ManagedShell here: cairoshell/ManagedShell#115

Hopefully this is sufficient to fix this issue. Will abandon this PR for now and revive it if it turns out Windows does not hide this folder consistently.

@dremin dremin closed this Dec 2, 2024
@dremin dremin deleted the filter-tombstones branch December 2, 2024 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants