-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for an additional pattern episode, season parsing #36
Conversation
WalkthroughThe changes in this pull request enhance the Changes
Possibly related PRs
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
PTT/handlers.py (1)
Line range hint
335-368
: Consider adding test cases for edge cases.While the current test coverage is good for the happy path, consider adding test cases for edge cases such as:
- Invalid season numbers (00, 100)
- Invalid episode numbers (0000)
- Mixed case variations (e vs E)
- Different separators (space, dot, underscore)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (3)
PTT/handlers.py
(6 hunks)tests/test_episodes.py
(1 hunks)tests/test_season.py
(1 hunks)
🔇 Additional comments (6)
tests/test_season.py (1)
114-114
: LGTM! Test case addition is appropriate.
The new test case "Vikkatakavi 01E06.mkv"
with expected season [1]
properly validates the parser's ability to extract season numbers from the "##E##" format.
tests/test_episodes.py (1)
193-193
: LGTM! Test case addition is appropriate.
The new test case "Vikkatakavi 01E06.mkv"
with expected episode [6]
properly validates the parser's ability to extract episode numbers from the "##E##" format.
PTT/handlers.py (4)
335-335
: LGTM! Season pattern handler is well-implemented.
The new season pattern handler correctly captures 1-2 digit season numbers in the format "##E##" with proper word boundaries.
368-368
: LGTM! Episode pattern handler is well-implemented.
The new episode pattern handler correctly captures 1-3 digit episode numbers in the format "##E##" with proper word boundaries.
599-601
: LGTM! Group handlers addition is appropriate.
The new group handlers for "INFLATE|DEFLATE" and "Erai-raws" follow the existing pattern for release group detection.
614-615
: LGTM! Title cleanup handler addition is appropriate.
The new title cleanup handler for "100 years quest" follows the existing pattern for title cleanup.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good!
Summary by CodeRabbit
New Features
Bug Fixes
Tests