Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1093] Exclude phpmd for deploy, post-update & install file. #1203

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

tannguyen04
Copy link
Contributor

@tannguyen04 tannguyen04 commented Feb 22, 2024

Checklist before requesting a review

closes #1093

  • I have formatted the subject to include ticket number as [#123] Verb in past tense with dot at the end.
  • I have added a link to the issue tracker
  • I have provided information in Changed section about WHY something was done if this was not a normal implementation
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • I have run new and existing relevant tests locally with my changes, and they passed
  • I have provided screenshots, where applicable

Changed

Screenshots

@tannguyen04 tannguyen04 changed the title Exclude phpmd for deploy, post-update & install file. [#1093] Exclude phpmd for deploy, post-update & install file. Feb 22, 2024
Copy link

codecov bot commented Feb 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0e6b027) 72.09% compared to head (3979395) 72.09%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1203   +/-   ##
========================================
  Coverage    72.09%   72.09%           
========================================
  Files           38       38           
  Lines         2849     2849           
========================================
  Hits          2054     2054           
  Misses         795      795           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AlexSkrypnyk AlexSkrypnyk merged commit 491f8da into develop Feb 22, 2024
15 checks passed
@AlexSkrypnyk AlexSkrypnyk deleted the drupal-update-hook-show-phpmd-warning branch February 22, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Drupal update hook comments show @SuppressWarnings(PHPMD.StaticAccess)
2 participants