Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1200] Added behat code coverage tool. #1229

Closed
wants to merge 9 commits into from

Conversation

richardgaunt
Copy link
Collaborator

@richardgaunt richardgaunt commented Mar 15, 2024

closes #1200

Checklist before requesting a review

  • I have formatted the subject to include ticket number as [#123] Verb in past tense with dot at the end.
  • I have added a link to the issue tracker
  • I have provided information in Changed section about WHY something was done if this was not a normal implementation
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • I have run new and existing relevant tests locally with my changes, and they passed
  • I have provided screenshots, where applicable

Changed

Screenshots

@github-actions github-actions bot added the PR: CONFLICT Pull request has a conflict that needs to be resolved before it can be merged label Mar 15, 2024
@richardgaunt richardgaunt force-pushed the add-behat-code-coverage branch from df9d379 to 8540392 Compare March 15, 2024 03:08
@richardgaunt richardgaunt force-pushed the add-behat-code-coverage branch from 8540392 to 4306986 Compare March 15, 2024 03:11
@github-actions github-actions bot removed the PR: CONFLICT Pull request has a conflict that needs to be resolved before it can be merged label Mar 15, 2024
@richardgaunt richardgaunt force-pushed the add-behat-code-coverage branch from 540929e to 000b0de Compare March 15, 2024 03:15
@richardgaunt richardgaunt force-pushed the add-behat-code-coverage branch from 000b0de to 8771ded Compare March 15, 2024 03:16
@richardgaunt richardgaunt changed the title Added behat code coverage tool. [#1200] Added behat code coverage tool. Mar 15, 2024
Copy link

codecov bot commented Mar 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.41%. Comparing base (543f8b5) to head (eda74b8).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1229      +/-   ##
===========================================
- Coverage    65.45%   65.41%   -0.04%     
===========================================
  Files           59       59              
  Lines         3303     3305       +2     
===========================================
  Hits          2162     2162              
- Misses        1141     1143       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AlexSkrypnyk
Copy link
Member

@richardgaunt
Thank you for working on this.
This tool only covers the code used to run the Behat tests, not the system under tests :(
Looks like it is not possible to implement the coverage for Drupal. Closing.

@AlexSkrypnyk AlexSkrypnyk deleted the add-behat-code-coverage branch March 16, 2024 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Consider adding behat-code-coverage for Behat code coverage
2 participants