Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#768] Added checking for bin existence in scripts. #1271

Closed
wants to merge 4 commits into from

Conversation

tannguyen04
Copy link
Contributor

@tannguyen04 tannguyen04 commented Apr 17, 2024

Checklist before requesting a review

closes #768

  • I have formatted the subject to include ticket number as [#123] Verb in past tense with dot at the end.
  • I have added a link to the issue tracker
  • I have provided information in Changed section about WHY something was done if this was not a normal implementation
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • I have run new and existing relevant tests locally with my changes, and they passed
  • I have provided screenshots, where applicable

Changed

Screenshots

@github-actions github-actions bot temporarily deployed to commit April 17, 2024 08:10 Inactive
@github-actions github-actions bot temporarily deployed to commit April 17, 2024 08:14 Inactive
@github-actions github-actions bot temporarily deployed to commit April 17, 2024 08:45 Inactive
Copy link

codecov bot commented Apr 17, 2024

Codecov Report

Attention: Patch coverage is 14.58333% with 82 lines in your changes are missing coverage. Please review.

Project coverage is 66.76%. Comparing base (3a97f9f) to head (e1a6b60).

Files Patch % Lines
scripts/drevops/download-db-acquia.sh 0.00% 4 Missing ⚠️
scripts/drevops/download-db-docker-registry.sh 0.00% 4 Missing ⚠️
scripts/drevops/download-db-ftp.sh 0.00% 4 Missing ⚠️
scripts/drevops/download-db-lagoon.sh 0.00% 4 Missing ⚠️
scripts/drevops/login-docker.sh 0.00% 4 Missing ⚠️
scripts/drevops/mirror-code.sh 0.00% 4 Missing ⚠️
scripts/drevops/task-copy-db-acquia.sh 0.00% 4 Missing ⚠️
scripts/drevops/task-copy-files-acquia.sh 0.00% 4 Missing ⚠️
scripts/drevops/task-custom-lagoon.sh 0.00% 4 Missing ⚠️
scripts/drevops/task-purge-cache-acquia.sh 0.00% 4 Missing ⚠️
... and 14 more
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1271      +/-   ##
===========================================
- Coverage    68.35%   66.76%   -1.60%     
===========================================
  Files           50       50              
  Lines         3087     3177      +90     
===========================================
+ Hits          2110     2121      +11     
- Misses         977     1056      +79     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot temporarily deployed to commit April 17, 2024 14:54 Inactive
@tannguyen04 tannguyen04 changed the title Examine all scripts in scripts/drevops for any binaries that are used… [#768] Examine for any binaries that are used and exit if they are not found Apr 17, 2024
@tannguyen04 tannguyen04 marked this pull request as ready for review April 17, 2024 15:34
@AlexSkrypnyk AlexSkrypnyk changed the title [#768] Examine for any binaries that are used and exit if they are not found [#768] Added checking for bin existence in scripts. Apr 17, 2024
@AlexSkrypnyk AlexSkrypnyk enabled auto-merge (squash) April 17, 2024 20:59
auto-merge was automatically disabled April 18, 2024 21:17

Pull request was closed

@AlexSkrypnyk AlexSkrypnyk deleted the featute/verbose-message-script branch April 18, 2024 21:17
@github-actions github-actions bot temporarily deployed to commit April 18, 2024 21:18 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Put a verbose message in all drevops scripts if the required binaries are not available
2 participants