Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed SSH setup not correctly processing false value from variable. #1288

Merged
merged 1 commit into from
Apr 26, 2024

Conversation

AlexSkrypnyk
Copy link
Member

No description provided.

@AlexSkrypnyk AlexSkrypnyk enabled auto-merge (rebase) April 26, 2024 02:34
Copy link

codecov bot commented Apr 26, 2024

Codecov Report

Attention: Patch coverage is 14.28571% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 57.53%. Comparing base (0d1d1c1) to head (6e3efc1).

Files Patch % Lines
.scaffold/tests/bats/_helper.bash 0.00% 7 Missing ⚠️
scripts/drevops/setup-ssh.sh 28.57% 5 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1288      +/-   ##
===========================================
- Coverage    66.82%   57.53%   -9.29%     
===========================================
  Files           50       50              
  Lines         3183     3184       +1     
===========================================
- Hits          2127     1832     -295     
- Misses        1056     1352     +296     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AlexSkrypnyk AlexSkrypnyk merged commit 9361fcc into develop Apr 26, 2024
18 of 20 checks passed
@AlexSkrypnyk AlexSkrypnyk deleted the feature/fix-ssh branch April 26, 2024 02:59
@AlexSkrypnyk AlexSkrypnyk added this to the 1.20.1 milestone Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant