Move DropletUtils to Suggests to reduce dependencies #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks Lukas! it seems alright, also all the check passed! |
drighelli
approved these changes
Sep 2, 2023
|
Thanks! |
|
Just pushed it to Bioc-devel (upstream) too |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the
DropletUtilspackage toSuggests:to reduce the overall number of dependencies forSpatialExperiment, as suggested by @ellispatrick in issue #139.I think this makes sense, since we only use
DropletUtils::read10xCounts()within our functionread10xVisium()and in some examples, so it doesn't really need to be installed by default along with its additional dependency tree.I also added an additional warning message at the start of
read10xVisium()ifDropletUtilsis not installed, since I believe the default R warning message when a package is missing is quite cryptic, so this could be confusing for novice users otherwise.Longer-term we are also planning to move
read10xVisium()out of theSpatialExperimentpackage and intoTENxIO, as discussed in issue waldronlab/TENxIO#3, but this PR should be a good intermediate improvement until that time.