Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add setConnectionCallback #2204

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add setConnectionCallback #2204

wants to merge 1 commit into from
+85 −2

Conversation

fantasy-peak
Copy link
Contributor

@dkalinowski
Copy link

dkalinowski commented Dec 2, 2024 •
edited
Loading

@fantasy-peak any update on this pull request? 😃

I have checked the example app showcasing the usage.
I don't think it is good idea to keep callback mapping in a global variable - wouldn't it be better to keep that mapping inside of connection object? (req->getConnectionPtr()) and let Drogon manage it automatically?

@fantasy-peak
Copy link
Contributor Author

@fantasy-peak any update on this pull request? 😃

I have checked the example app showcasing the usage. I don't think it is good idea to keep callback mapping in a global variable - wouldn't it be better to keep that mapping inside of connection object? (req->getConnectionPtr()) and let Drogon manage it automatically?

I've been busy with other things lately，You can modify it on the basis of my mr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fantasy-peak @dkalinowski