[feat]: [CI-15228]: Embed and load buildkit image in drone buildx #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
| // Read the tarball from the embedded filesystem | ||
| data, err := buildkitTarball.ReadFile("buildkit/buildkit.tar") |
There was a problem hiding this comment.
there should be a file exist check. This file would only exist in container
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we will first create a tarball for the buildkit image using release.sh before creating the binary. Then in the code we have made changes to load the buildkit.tar and also override the builder opts buildkit image with the version given in drone buildx version.json
This PR also fixes fallback logic of buildkit driver opts