Updates dropshots to always write reference image. #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adecker89
approved these changes
Oct 24, 2024
This seems weird, but matches the behavior of the connected instrument test task, so 🤷.
|
when the assertion is done, could we record the screenshot simultaneously? It would prevent us from re-running the test if we agree with the changes |
That's what I'm working on now with this change. Sorry for the thrash in this PR, but validating the GHA integration is hard to do without a PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the behavior of the plugin to remove the need for the
dropshots.recordproperty, which broke configuration caching. With that being deprecated, the new way to record new reference screenshots is by using therecordDebugScreenshotsgradle task.Since switching to a task means we won't be compiling a new APK for the test, the updated behavior is to use a marker file written to the emulator to disable assertion failures when recording new screenshots.