Check CallLimitValidator only at startup (#479)

* Check CallLimitValidator only at startup checks * simplify code
drpcorg · May 20, 2024 · 4f36257 · 4f36257
1 parent f6090a4
commit 4f36257
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 4 deletions.
diff --git a/src/main/kotlin/io/emeraldpay/dshackle/upstream/UpstreamValidator.kt b/src/main/kotlin/io/emeraldpay/dshackle/upstream/UpstreamValidator.kt
@@ -34,8 +34,8 @@ abstract class UpstreamValidator(
 
     abstract fun validateUpstreamSettings(): Mono<ValidateUpstreamSettingsResult>
 
-    fun validateUpstreamSettingsOnStartup(): ValidateUpstreamSettingsResult {
-        return validateUpstreamSettings().block() ?: ValidateUpstreamSettingsResult.UPSTREAM_FATAL_SETTINGS_ERROR
+    open fun validateUpstreamSettingsOnStartup(): ValidateUpstreamSettingsResult {
+        return ValidateUpstreamSettingsResult.UPSTREAM_VALID
     }
 
     companion object {

diff --git a/src/main/kotlin/io/emeraldpay/dshackle/upstream/ethereum/EthereumUpstreamValidator.kt b/src/main/kotlin/io/emeraldpay/dshackle/upstream/ethereum/EthereumUpstreamValidator.kt
@@ -80,11 +80,23 @@ open class EthereumUpstreamValidator @JvmOverloads constructor(
         }
         return Mono.zip(
             validateChain(),
-            validateCallLimit(),
             validateOldBlocks(),
         ).map {
-            listOf(it.t1, it.t2, it.t3).sorted().last()
+            listOf(it.t1, it.t2).maxOf { it }
+        }
+    }
+
+    override fun validateUpstreamSettingsOnStartup(): ValidateUpstreamSettingsResult {
+        if (options.disableUpstreamValidation) {
+            return ValidateUpstreamSettingsResult.UPSTREAM_VALID
         }
+        return Mono.zip(
+            validateChain(),
+            validateOldBlocks(),
+            validateCallLimit(),
+        ).map {
+            listOf(it.t1, it.t2, it.t3).maxOf { it }
+        }.block() ?: ValidateUpstreamSettingsResult.UPSTREAM_SETTINGS_ERROR
     }
 
     private fun validateChain(): Mono<ValidateUpstreamSettingsResult> {