Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix deadlock, remove setting UNAVAIL status #333

Merged
merged 6 commits into from
Nov 6, 2023
Merged

Fix deadlock, remove setting UNAVAIL status #333

merged 6 commits into from
Nov 6, 2023

Conversation

KirillPamPam
Copy link
Contributor

  • fix deadlock which was caused by using eventPublisher in headLiveness subscription - updating capabilities is done by sink
  • remove setting UNAVAILABLE statuses on ws disconnects and errors while getting heads, they are just useless cause we have periodically validation checks which set OK status. Even more if these validations are turned off, upstream won't be able to restore OK status
  • remove WS capability immediately when WS disconnect occurs

@KirillPamPam KirillPamPam merged commit e4c13ad into master Nov 6, 2023
1 check passed
@KirillPamPam KirillPamPam deleted the fix_deadlock branch November 6, 2023 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a10zn8 a10zn8 a10zn8 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KirillPamPam @a10zn8