Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Poll rpc heads using expected-block-time #338

Merged
merged 4 commits into from
Nov 10, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,15 @@ class GenericRpcConnector(
head = when (connectorType) {
RPC_ONLY -> {
log.warn("Setting up connector for $id upstream with RPC-only access, less effective than WS+RPC")
GenericRpcHead(getIngressReader(), forkChoice, id, blockValidator, headScheduler, chainSpecific)
GenericRpcHead(
getIngressReader(),
forkChoice,
id,
blockValidator,
headScheduler,
chainSpecific,
expectedBlockTime.coerceAtLeast(Duration.ofSeconds(1)),
)
}

WS_ONLY -> {
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,71 @@
package io.emeraldpay.dshackle.upstream.generic.connectors

import io.emeraldpay.dshackle.Chain
import io.emeraldpay.dshackle.FileResolver
import io.emeraldpay.dshackle.config.ChainsConfig
import io.emeraldpay.dshackle.config.ChainsConfigReader
import io.emeraldpay.dshackle.config.UpstreamsConfig
import io.emeraldpay.dshackle.foundation.ChainOptionsReader
import io.emeraldpay.dshackle.startup.configure.GenericConnectorFactoryCreator
import io.emeraldpay.dshackle.upstream.BlockValidator
import io.emeraldpay.dshackle.upstream.DefaultUpstream
import io.emeraldpay.dshackle.upstream.forkchoice.AlwaysForkChoice
import io.emeraldpay.dshackle.upstream.generic.GenericRpcHead
import org.junit.jupiter.api.Assertions.assertEquals
import org.junit.jupiter.params.ParameterizedTest
import org.junit.jupiter.params.provider.Arguments
import org.junit.jupiter.params.provider.MethodSource
import org.mockito.Mockito.mockConstruction
import org.mockito.kotlin.doReturn
import org.mockito.kotlin.mock
import reactor.core.scheduler.Schedulers.immediate
import java.io.File
import java.net.URI
import java.time.Duration

class GenericConnectorFactoryCreatorTest {

@ParameterizedTest
@MethodSource("data")
fun `rpc head poll interval must equal to expected-block-time`(
expectedBlockTime: Duration,
config: ChainsConfig.ChainConfig,
) {
val factory = GenericConnectorFactoryCreator(
FileResolver(File("")),
immediate(),
immediate(),
immediate(),
immediate(),
)
var args: List<*>? = null

mockConstruction(GenericRpcHead::class.java) { _, ctx -> args = ctx.arguments() }
.use {
factory.createConnectorFactoryCreator(
"id",
UpstreamsConfig.RpcConnection(
UpstreamsConfig.HttpEndpoint(URI("http://localhost")),
),
Chain.ETHEREUM__MAINNET,
AlwaysForkChoice(),
BlockValidator.ALWAYS_VALID,
config,
)?.create(mock<DefaultUpstream> { on { getId() } doReturn "id" }, Chain.ETHEREUM__MAINNET)

assertEquals(expectedBlockTime, args?.get(6))
}
}

companion object {
private val chainsConfigReader = ChainsConfigReader(ChainOptionsReader())

@JvmStatic
fun data(): List<Arguments> = chainsConfigReader.read(null)
.flatMap { cfg ->
cfg.shortNames.map {
Arguments.of(cfg.expectedBlockTime.coerceAtLeast(Duration.ofSeconds(1)), cfg)
}
}
}
}
Loading