Frozen objects in WeakMap

* gc.c (wmap_aset): bypass check for frozen and allow frozen object in WeakMap. [Bug #13498]
dryruby · Jun 22, 2019 · f3c81b4 · f3c81b4
1 parent f5e2904
commit f3c81b4
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 3 deletions.
diff --git a/gc.c b/gc.c
@@ -2937,13 +2937,20 @@ should_be_callable(VALUE block)
 		 rb_obj_class(block));
     }
 }
+
 static void
-should_be_finalizable(VALUE obj)
+should_be_finalizable_internal(VALUE obj)
 {
     if (!FL_ABLE(obj)) {
 	rb_raise(rb_eArgError, "cannot define finalizer for %s",
 		 rb_obj_classname(obj));
     }
+}
+
+static void
+should_be_finalizable(VALUE obj)
+{
+    should_be_finalizable_internal(obj);
     rb_check_frozen(obj);
 }
 
@@ -10399,8 +10406,8 @@ wmap_aset(VALUE self, VALUE wmap, VALUE orig)
     struct weakmap *w;
 
     TypedData_Get_Struct(self, struct weakmap, &weakmap_type, w);
-    should_be_finalizable(orig);
-    should_be_finalizable(wmap);
+    should_be_finalizable_internal(orig);
+    should_be_finalizable_internal(wmap);
     define_final0(orig, w->final);
     define_final0(wmap, w->final);
     st_update(w->obj2wmap, (st_data_t)orig, wmap_aset_update, wmap);

diff --git a/test/ruby/test_weakmap.rb b/test/ruby/test_weakmap.rb
@@ -141,4 +141,10 @@ def test_size
     assert_equal(2, @wm.__send__(m))
   end
   alias test_length test_size
+
+  def test_frozen_object
+    o = Object.new.freeze
+    assert_nothing_raised(FrozenError) {@wm[o] = 'foo'}
+    assert_nothing_raised(FrozenError) {@wm['foo'] = o}
+  end
 end