Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UpdateServicesComputerTargetGroup: (new resource) Computer Target Group Creation / Deletion #60

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

oliveirt
Copy link

@oliveirt oliveirt commented Nov 24, 2020

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry under the Unreleased section of the change log in the CHANGELOG.md.
    Entry should say what was changed, and how that affects users (if applicable).
  • Resource documentation added/updated in README.md.
  • Resource parameter descriptions added/updated in README.md, schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Resource Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
  • New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

This change is Reviewable

@Borgquite
Copy link
Contributor

@gaelcolas @johlju What would be needed to revive this repository and specifically this pull request? I can do some smaller updates if it’s just rotted due to subsequent updates…

@johlju
Copy link
Member

johlju commented May 27, 2024

@Borgquite do you have time to review this PR? If you feel it looks okay to you I will merge it.

@johlju
Copy link
Member

johlju commented May 27, 2024

This PR also need to be rebased. I tried to do it, but there were a lot of conflicts, to many for me to have time to fix. So either if @oliveirt can rebase, or if @Borgquite maybe you can send in a new PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants