feat: publish package to registry (DCP-1814) 🎉 #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinayakkulkarni
commented
Apr 29, 2024
•
vinayakkulkarni
commented
- Enables ship.js trigger to publish to GPR
- Updated meta files & removed duplicate prettier config files
- Clean up GitHub action workflows
- Add support for Husky & Commitlint to adhere to conventional commits so we can follow SemVer
- Add implementation in https://github.com/dscvr-one/dscvr-media-worker/pull/76
added 9 commits
April 29, 2024 07:09
Signed-off-by: Vinayak Kulkarni <[email protected]>
Signed-off-by: Vinayak Kulkarni <[email protected]>
Signed-off-by: Vinayak Kulkarni <[email protected]>
Signed-off-by: Vinayak Kulkarni <[email protected]>
Signed-off-by: Vinayak Kulkarni <[email protected]>
Signed-off-by: Vinayak Kulkarni <[email protected]>
Signed-off-by: Vinayak Kulkarni <[email protected]>
Signed-off-by: Vinayak Kulkarni <[email protected]>
Signed-off-by: Vinayak Kulkarni <[email protected]>
added 6 commits
April 29, 2024 07:21
Signed-off-by: Vinayak Kulkarni <[email protected]>
Signed-off-by: Vinayak Kulkarni <[email protected]>
Signed-off-by: Vinayak Kulkarni <[email protected]>
Signed-off-by: Vinayak Kulkarni <[email protected]>
Signed-off-by: Vinayak Kulkarni <[email protected]>
Signed-off-by: Vinayak Kulkarni <[email protected]>
jimmymadrigal
requested changes
Apr 29, 2024
Since this is a public fork, it is a public package. |
added 3 commits
April 29, 2024 21:52
Signed-off-by: Vinayak Kulkarni <[email protected]>
Signed-off-by: Vinayak Kulkarni <[email protected]>
Signed-off-by: Vinayak Kulkarni <[email protected]>
vinayakkulkarni
changed the title
added 2 commits
April 30, 2024 06:01
Signed-off-by: Vinayak Kulkarni <[email protected]>
Signed-off-by: Vinayak Kulkarni <[email protected]>
ncpenke
reviewed
Apr 30, 2024
ncpenke
approved these changes
Apr 30, 2024
There was a problem hiding this comment.
LGTM - but please wait till approval from @jimmymadrigal or @PipDscvr. Thank you!
jimmymadrigal
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.