Skip to content

Commit

Permalink
Dev (#68)
Browse files Browse the repository at this point in the history
* add delimeter detection

* fix documentation

* update the documentation vs actual code

* cannot access data via `$`for some reason. but now it will only load files called out in the readme, resolving issue #20

* drop show_readme function - redundant to readme function

* bump version

* improve read speed, and add user ability to pass args to tt_read_data from tt_load

* resolve build check errors, make readme exported...

* try rolling back and specifying min version of rlang necessary

* move up rlang and dplyr version

* update min package versions for travis?

* update minimum package versions

* attempting to make pkgdown site for {tidytuesdayR}

* bump version to dev number

* add print method and add more tests

* update documentation for print method

* Add README.Rmd

* Make pkgdown work (#32)

* try to get pkgdown to use the readme

* Add pkgdown to suggests

* Update DESCRIPTION

bump version number

* remove README.Rmd

* Gdpr data (#45)

* Path replace fix (#43)

* update URL path corrections

* Improvement on file-finding abilities...

* first updates to api

* update github calls to add blob and authentication

* working on updating file downloading via github api

* updates to allow for setting ref repo in options

* add documentation

* updates to printing tt_available

* updates to tests & docs to pass devtools::check

* add auth to downloading sha within tt_download

* Looking to remove travis/appveyor dep

* update to reference full path and stringsAsFactors not being TRUE by default now.

* Add token to github_pat function

* add GITHUB_PAT as token

* add travis and appveyor back in

* hopefully this fixes appveyor

* remove travis and move code coverage to github actions (#49)

* update news, bump major version

* add github api limiting feature

* Cran release prep v1 (#52)

* prepping for CRAN release

* Add Cran Comments

* Increment version number

* Tidytemplates (#61)

* Create tidytemplate

* update documentation

* update for missing imports and partial arg match

* complete updates to tidytemplate

* wrap tests in tt_ref_test_that and add api check

* html encoding error (#62)

* unpdate to allow for general encoding

* Fix so only specific locale needed updating (CTYPE)

* Increment version number

* update news

* add CRAN comments

* spelling

* cran release

* update func to pass args to parsing funcs

* Increment version number

* Update github_api.R (#67)

malformed check against github api, for some reason worked everywhere but rstudio cloud? #65

* Documentation correction (#70)

* Update to make missing delim acceptable (#66)

* Update to make missing delim acceptable

* Update R-CMD-check.yaml

* Update R-CMD-check.yaml

undo updates 🙄

* Update tt_download.R

Correct documentation

* update docs

* fix order of link and code
  • Loading branch information
Ellis Hughes authored Aug 19, 2020
1 parent 38f3d43 commit 51dfba6
Show file tree
Hide file tree
Showing 7 changed files with 9 additions and 9 deletions.
4 changes: 2 additions & 2 deletions CRAN-RELEASE
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
This package was submitted to CRAN on 2020-06-25.
Once it is accepted, delete this file and tag the release (commit e11af077e1).
This package was submitted to CRAN on 2020-07-09.
Once it is accepted, delete this file and tag the release (commit 042d9a2d32).
2 changes: 1 addition & 1 deletion DESCRIPTION
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
Package: tidytuesdayR
Type: Package
Title: Access the Weekly 'TidyTuesday' Project Dataset
Version: 1.0.1
Version: 1.0.1.9000
Authors@R:
c(
person(
Expand Down
2 changes: 2 additions & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
# tidytuesdayR (development version)

# tidytuesdayR 1.0.1

* [feature] Provide a template Rmd for users, populated with date and proper `tt_load` call
Expand Down
2 changes: 1 addition & 1 deletion R/github_api.R
Original file line number Diff line number Diff line change
Expand Up @@ -492,7 +492,7 @@ check_connectivity <- function(rerun = FALSE){
#if internet connection is not set or is false, lets try again
if(!getOption("tidytuesdayR.tt_testing", FALSE)){
if(is.na(internet_connection) | !internet_connection | rerun){
res <- try(GET("https:/api.github.com"), silent = TRUE)
res <- try(GET("https://api.github.com"), silent = TRUE)
if(inherits(res,"try-error")){
options("tidytuesdayR.tt_internet_connectivity" = FALSE)
}else{
Expand Down
3 changes: 1 addition & 2 deletions R/tt_download.R
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,7 @@
#'
#' Download all or specific files identified in the tt dataset
#'
#' @param tt string representation of the date of data to pull, in YYYY-MM-dd
#' format, or just numeric entry for year
#' @param tt a `tt` object, output from \code{\link{tt_load_gh}}
#' @param files List the file names to download. Default to asking.
#' @param ... pass methods to the parsing functions. These will be passed to
#' ALL files, so be careful.
Expand Down
2 changes: 1 addition & 1 deletion R/tt_download_file.R
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ tt_download_file.character <-
auth = auth
)

tt_parse_blob(blob, file_info = file_info[file_info$data_file == x,])
tt_parse_blob(blob, file_info = file_info[file_info$data_file == x,], ...)

} else {
stop(paste0(
Expand Down
3 changes: 1 addition & 2 deletions man/tt_download.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 51dfba6

Please sign in to comment.