Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hand GitHub handling over to gh. #101

Merged
merged 10 commits into from
Aug 31, 2024
Merged

Hand GitHub handling over to gh. #101

merged 10 commits into from
Aug 31, 2024

Conversation

jonthegeek
Copy link
Collaborator

This is a fairly huge refactor to let {gh} deal with all of the connection stuff, and to mock tests while we're at it.

Lots of tests will fail when I first check this in, but I wanted to create the draft so you know I'm working on it. It's beginning to move more rapidly so I hope to knock this out in the next day or three. (if I remember to, I'll remove this message when the PR is ready).

Closes #77.
Closes #78.
Closes #79.
Closes #97.
Closes #99.

@jonthegeek jonthegeek marked this pull request as ready for review August 28, 2024 23:17
@jonthegeek
Copy link
Collaborator Author

@thebioengineer This turned into a fairly gigantic PR. We use {gh} for all the github stuff now, and all tests are mocked (so you can run the test suite without internet).

Of course I see that the workflows are failing, so something isn't quite perfect yet...

I'll tweak these more when we move the repo, but I'm pre-checking some things for CRAN update.
@thebioengineer thebioengineer merged commit a58273b into master Aug 31, 2024
9 checks passed
@jonthegeek jonthegeek deleted the simplify-gh branch September 3, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants