[FIX] test code and validate logic

dsm-pear · May 26, 2021 · 6020b1d · 6020b1d
1 parent de4968d
commit 6020b1d
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 6 deletions.
diff --git a/src/main/java/com/dsmpear/main/user_backend_v2/config/validation/GithubUrlValidator.java b/src/main/java/com/dsmpear/main/user_backend_v2/config/validation/GithubUrlValidator.java
@@ -10,16 +10,14 @@
 @Component
 public class GithubUrlValidator implements ConstraintValidator<ValidateGithubUrl, String> {
 
-    private static final String HTTP_GITHUB_LINK = "http://github.com";
-    private static final String HTTPS_GITHUB_LINK = "https://github.com";
+    private static final String GITHUB_LINK = "github.com";
 
     @Override
     public boolean isValid(String url, ConstraintValidatorContext context) {
         return url == null || isStartsWithGithub(url);
     }
 
     private boolean isStartsWithGithub(String url) {
-        return url.startsWith(HTTP_GITHUB_LINK)
-                || url.startsWith(HTTPS_GITHUB_LINK);
+        return url.contains(GITHUB_LINK);
     }
 }
diff --git a/src/test/java/com/dsmpear/main/user_backend_v2/ReportControllerTest.java b/src/test/java/com/dsmpear/main/user_backend_v2/ReportControllerTest.java
@@ -189,7 +189,7 @@ private SoleReportRequest buildSoleRequest(String title) {
                 .languages(Arrays.asList("sdf","asdfsa"))
                 .isSubmitted(true)
                 .grade(Grade.GRADE1)
-                .github("sf")
+                .github("github.com")
                 .field(Field.WEB)
                 .description("description")
                 .access(Access.EVERY)
@@ -205,7 +205,7 @@ private TeamReportRequest buildTeamRequest(String title) {
                 .languages(Arrays.asList("sdf","asdfsa"))
                 .isSubmitted(true)
                 .grade(Grade.GRADE1)
-                .github("sf")
+                .github("github.com")
                 .field(Field.WEB)
                 .description("description")
                 .access(Access.EVERY)