Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes url for list_recursive on win in remote #144

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

TylerGubala
Copy link

  • remote client used to make bad urls on windows
  • due to os.path.join, urls contained backslash-escaped chars
  • now remotes use posixpath.join, which is safe for urls

This addresses issues found in #139

- remote client used to make bad urls on windows
- due to os.path.join, urls contained backslash-escaped chars
- now remotes use posixpath.join, which is safe for urls
@coveralls
Copy link

Coverage Status

Coverage decreased (-32.0%) to 68.0% when pulling e659f0f on TylerGubala:remote-winfix into 0c222a9 on dsoprea:master.

@@ -0,0 +1,3 @@
{
"python.pythonPath": "c:\\Users\\TGubs\\Code\\Python\\PySvn\\venv\\Scripts\\python.exe"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove.

You may want to add .vscode/ to your ~/.gitignore.

@dsoprea dsoprea force-pushed the master branch 2 times, most recently from 544f7da to 230a2cd Compare February 1, 2020 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants