Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add base64 as dependency #107

Closed
wants to merge 1 commit into from
Closed

add base64 as dependency #107

wants to merge 1 commit into from

Conversation

mmenanno
Copy link

@mmenanno mmenanno commented Jan 8, 2024

As of ruby 3.3.0 I started getting the warning:

/Users/username/.gem/ruby/3.3.0/gems/safe_yaml-1.0.5/lib/safe_yaml/transform.rb:1: warning: base64 was loaded from the standard library, but will no longer be part of the default gems since Ruby 3.4.0. Add base64 to your Gemfile or gemspec. Also contact author of safe_yaml-1.0.5 to add base64 into its gemspec.

So I added it to the gemspec. There aren't many versions of the gem but looking at the release notes for base64 I think it is fine to have really any version of it, so I made the version requirement anything from 0.1.0 or greater

Notably if we wanted, this could be a conditional dependency on the ruby version wrapped with something like:

if Gem::Version.new(RUBY_VERSION) >= Gem::Version.new('3.3')
  s.add_dependency("base64", ">= 0.1.0")
end

@mmenanno mmenanno closed this by deleting the head repository Feb 6, 2024
@perlun
Copy link

perlun commented Jul 21, 2024

@mmenanno Please consider reopening this PR. This is a real problem that will hit people when Ruby 3.4 is released.

@mmenanno
Copy link
Author

Yup! I'll get another PR up, looks like I accidentally closed this by cleaning up forks that I thought I didn't need anymore.

@mmenanno
Copy link
Author

Reopened here #110 @perlun

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants