Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add regression tests for issue #67 #73

Merged
merged 1 commit into from
Oct 7, 2023
Merged

Add regression tests for issue #67 #73

merged 1 commit into from
Oct 7, 2023

Conversation

stphnt
Copy link
Contributor

@stphnt stphnt commented Oct 7, 2023

These tests should help ensure #67 doesn't come back.

Prior to merging #72, these tests causes either STATUS_ACCESS_VIOLATION or STATUS_ILLEGAL_OPERATION on Windows (MSVC). With #72 they pass.

dtolnay
dtolnay approved these changes Oct 7, 2023
View reviewed changes
Copy link
Owner

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dtolnay dtolnay merged commit 9d6d5a8 into dtolnay:master Oct 7, 2023
10 of 13 checks passed
@stphnt stphnt deleted the windows-access-violation-regression-tests branch October 7, 2023 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtolnay dtolnay dtolnay approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stphnt @dtolnay