-
Notifications
You must be signed in to change notification settings - Fork 911
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add simplified ("toggle") broken site reporting #5280
Open
laghee
wants to merge
24
commits into
develop
Choose a base branch
from
feature/kate/add-toggle-report
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmac012
reviewed
Nov 18, 2024
private val toggleReportsDataStore: ToggleReportsDataStore, | ||
@AppCoroutineScope private val coroutineScope: CoroutineScope, | ||
private val dispatcherProvider: DispatcherProvider, | ||
) : FeatureSettings.Store { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This API has been recently deprecated. You can now access feature settings using Toggle::getSettings()
- can you migrate to the new API? I'm assuming this shouldn't require much effort, but If I'm wrong then it's fine to leave it as is.
lmac012
reviewed
Nov 19, 2024
...oard-impl/src/main/java/com/duckduckgo/privacy/dashboard/impl/ui/PrivacyDashboardRenderer.kt
Outdated
Show resolved
Hide resolved
lmac012
reviewed
Nov 19, 2024
privacy-dashboard/privacy-dashboard-impl/src/test/java/ToggleReportsDataStoreTest.kt
Outdated
Show resolved
Hide resolved
lmac012
reviewed
Nov 19, 2024
...dashboard-impl/src/main/java/com/duckduckgo/privacy/dashboard/impl/ToggleReportsDataStore.kt
Outdated
Show resolved
Hide resolved
lmac012
reviewed
Nov 19, 2024
lmac012
reviewed
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1201870266890790/1208769785329643/f
Description
We're implementing the simplified broken site reporting flow that already exists on other platforms here, prompting users to report site breakage on URLs where they toggle off protections.
Steps to test this PR
Toggle Reports
app/build.gradle
to point to its location (replacing this bit).m_protection-toggled-off-breakage-report
pixel is sent withreportFlow=on_protections_off_dashboard_main
reportFlow=on_protections_off_menu