-
Notifications
You must be signed in to change notification settings - Fork 921
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Send app version on search pixel #5287
Merged
malmstein
merged 14 commits into
develop
from
feature/david/11-19-added_new_build_config_property
Nov 26, 2024
Merged
Send app version on search pixel #5287
malmstein
merged 14 commits into
develop
from
feature/david/11-19-added_new_build_config_property
Nov 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malmstein
changed the title
added new build config property
Add app version to browser feature pixel
Nov 19, 2024
malmstein
changed the title
Add app version to browser feature pixel
Send app version on search pixel
Nov 19, 2024
...src/test/java/com/duckduckgo/app/browser/trafficquality/RealQualityAppVersionProviderTest.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/duckduckgo/app/browser/trafficquality/QualityAppVersionProvider.kt
Outdated
Show resolved
Hide resolved
malmstein
force-pushed
the
feature/david/11-19-added_new_build_config_property
branch
from
November 20, 2024 10:42
c1c08a9
to
31958d3
Compare
malmstein
force-pushed
the
feature/david/11-19-added_new_build_config_property
branch
from
November 22, 2024 16:44
31958d3
to
b979cb7
Compare
joshliebe
approved these changes
Nov 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! ✅
Thanks @joshliebe ! |
malmstein
deleted the
feature/david/11-19-added_new_build_config_property
branch
November 26, 2024 09:37
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1174433894299346/1208776505075744/f
Description
We want to add a new temporary triggered on searches where we’ll send the app version.
There are few conditions, please refer to the task for more info.
Testing scenarios -> https://app.asana.com/0/1174433894299346/1208801300909712/f