Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send app version on search pixel #5287

Merged
merged 14 commits into from
Nov 26, 2024

Conversation

malmstein
Copy link
Contributor

@malmstein malmstein commented Nov 19, 2024

Task/Issue URL: https://app.asana.com/0/1174433894299346/1208776505075744/f

Description

We want to add a new temporary triggered on searches where we’ll send the app version.
There are few conditions, please refer to the task for more info.

Testing scenarios -> https://app.asana.com/0/1174433894299346/1208801300909712/f

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@malmstein malmstein changed the title added new build config property Add app version to browser feature pixel Nov 19, 2024
@malmstein malmstein marked this pull request as ready for review November 19, 2024 16:09
@malmstein malmstein changed the title Add app version to browser feature pixel Send app version on search pixel Nov 19, 2024
@malmstein malmstein force-pushed the feature/david/11-19-added_new_build_config_property branch from c1c08a9 to 31958d3 Compare November 20, 2024 10:42
@malmstein malmstein force-pushed the feature/david/11-19-added_new_build_config_property branch from 31958d3 to b979cb7 Compare November 22, 2024 16:44
@joshliebe joshliebe self-assigned this Nov 25, 2024
Copy link
Contributor

@joshliebe joshliebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✅

@malmstein
Copy link
Contributor Author

Thanks @joshliebe !

@malmstein malmstein merged commit 8fd697f into develop Nov 26, 2024
7 checks passed
@malmstein malmstein deleted the feature/david/11-19-added_new_build_config_property branch November 26, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants