Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

request translations for sync switching backup #5321

Open
wants to merge 20 commits into
base: develop
Choose a base branch
from

Conversation

cmonfortep
Copy link
Contributor

Task/Issue URL: https://app.asana.com/0/72649045549333/1208849498157786/f

Description

Steps to test this PR

Feature 1

  • [ ]
  • [ ]

UI changes

Before After
!(Upload before screenshot) (Upload after screenshot)

@cmonfortep
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

<string name="sync_dialog_switch_account_header">Switch to a different Sync?</string>
<string name="sync_dialog_switch_account_primary_button">Switch Sync</string>
<string name="sync_dialog_switch_account_secondary_button">Cancel</string>
<string name="sync_dialog_switch_account_description">This device is already synced, are you sure you want to sync it with a different back up or device? Switching won\'t remove any data already synced to this device.</string>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The term back up appears to be used as a noun in this string, where backup would be grammatically correct. Suggested revision:

This device is already synced, are you sure you want to sync it with a different backup or device? Switching won't remove any data already synced to this device.

Spotted by Graphite Reviewer

Is this helpful? React 👍 or 👎 to let us know.

Translate strings to values-es
Translate strings to values-ro
Translate strings to values-tr
Translate strings to values-sk
Translate strings to values-ru
Translate strings to values-et
Translate strings to values-it
Translate strings to values-pl
Translate strings to values-bg
Translate strings to values-lv
Translate strings to values-fi
Translate strings to values-sl
Translate strings to values-nl
Translate strings to values-hr
Translate strings to values-hu
Translate strings to values-nb
Translate strings to values-sv
Translate strings to values-da
Translate strings to values-el
Translate strings to values-fr
Translate strings to values-lt
Translate strings to values-pt
Translate strings to values-cs
Translate strings-autofill-impl to values-nl
Translate strings-autofill-impl to values-it
Translate strings-autofill-impl to values-ro
Translate strings-autofill-impl to values-sk
Translate strings-autofill-impl to values-sv
Translate strings-autofill-impl to values-bg
Translate strings-autofill-impl to values-fr
Translate strings-autofill-impl to values-sl
Translate strings-autofill-impl to values-lt
Translate strings-autofill-impl to values-el
Translate strings-autofill-impl to values-pt
Translate strings-autofill-impl to values-et
Translate strings-autofill-impl to values-nb
Translate strings-autofill-impl to values-de
Translate strings-autofill-impl to values-ru
Translate strings-autofill-impl to values-tr
Translate strings-autofill-impl to values-hu
Translate strings-autofill-impl to values-fi
Translate strings-autofill-impl to values-lv
Translate strings-autofill-impl to values-pl
Translate strings-autofill-impl to values-da
Translate strings-autofill-impl to values-es
Translate strings-autofill-impl to values-cs
Translate strings-saved-sites to values-nb
Translate strings-saved-sites to values-lt
Translate strings-saved-sites to values-sl
Translate strings-saved-sites to values-pt
Translate strings-saved-sites to values-fr
Translate strings-saved-sites to values-de
Translate strings-saved-sites to values-hu
Translate strings-saved-sites to values-hr
Translate strings-saved-sites to values-da
Translate strings-saved-sites to values-tr
Translate strings-saved-sites to values-ru
Translate strings-saved-sites to values-bg
Translate strings-saved-sites to values-it
Translate strings-saved-sites to values-pl
Translate strings-saved-sites to values-sv
Translate strings-saved-sites to values-et
Translate strings-saved-sites to values-nl
Translate strings-saved-sites to values-ro
Translate strings-saved-sites to values-lv
Translate strings-saved-sites to values-sk
Translate strings-saved-sites to values-fi
Translate strings-saved-sites to values-el
Translate strings-saved-sites to values-cs
<string name="sync_dialog_switch_account_header">Prepnúť na inú synchronizáciu?</string>
<string name="sync_dialog_switch_account_primary_button">Prepnutie synchronizácie</string>
<string name="sync_dialog_switch_account_secondary_button">Zrušiť</string>
<string name="sync_dialog_switch_account_description">Toto zariadenie je už synchronizované. Naozaj ho že chceš synchronizovať s inou zálohou alebo zariadením? Prepínanie neodstráni žiadne údaje, ktoré už boli synchronizované s týmto zariadením.</string>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Slovak translation contains a grammatical error in Naozaj ho že chceš. The correct word order in Slovak should be Naozaj chceš, without ho že between these words. This change will make the translation more natural and grammatically correct.

Spotted by Graphite Reviewer

Is this helpful? React 👍 or 👎 to let us know.

<string name="preciseLocationSiteDialogSubtitle">Oprávnění k přístupu k poloze, která jste udělili jednotlivým webovým stránkám, můžete spravovat v Nastavení.</string>
<string name="preciseLocationDDGDialogSubtitle">Tvou anonymní polohu používáme jen k tomu, abychom ti mohli poskytovat lepší výsledky v tvojí blízkosti. Oprávnění k přístupu k poloze udělené jednotlivým webovým stránkám můžeš spravovat v Nastaveních.</string>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Czech translation inconsistently uses both formal (vaši) and informal (tvou) pronouns in the same dialog text. For clarity and professionalism, the text should use either formal or informal pronouns consistently throughout. Consider standardizing on one form to maintain a consistent tone when addressing the user.

Spotted by Graphite Reviewer

Is this helpful? React 👍 or 👎 to let us know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants