Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore previous rules for popups in top-frame #18

Merged
merged 3 commits into from
Dec 6, 2023

Conversation

SlayterDev
Copy link
Contributor

Task/Issue URL: https://app.asana.com/0/1163321984198618/1205929348941245/f
Tech Design URL:
CC: @brindy @bwaresiak

Description:
This PR fixes issues of navigating to a URL on the blocklist through top-level navigation initiated by window.open

Steps to test this PR:

  1. Use this JSON for your config: https://www.jsonblob.com/1178775722532921344
  2. Go to https://www.troublefreepool.com/google-search/?q=ph+balance click on a result
  3. The result should open in a new tab
  4. Search on DDG for "reddit cats"
  5. CMD+click a result for a subreddit. The page should open in a new tab

OS Testing:

  • iOS 14

  • iOS 15

  • macOS 10.15

  • macOS 11

  • macOS 12


Internal references:

Software Engineering Expectations
Technical Design Template

Copy link
Contributor

@brindy brindy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some swift lint warnings to fix. Also we have tests that run this code and don't break so that's good, but it'd also be good if there was at least one test that asserted the output from this change.

Copy link
Contributor

@brindy brindy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Tested the scenarios listed and some general browsing on macOS and iOS and seems fine.

@SlayterDev SlayterDev merged commit a6b7ba1 into main Dec 6, 2023
3 checks passed
@SlayterDev SlayterDev deleted the brad/window-open-fix branch December 6, 2023 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants