Remove deprecated duckduckgo-colors dependency; fix sass warnings #2881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sammacbeth
force-pushed
the
sam/colors-deprecated
branch
from
4d7ab31 to
1c0a7f7
Compare
sammacbeth
changed the title
sammacbeth
force-pushed
the
sam/colors-deprecated
branch
from
f444d0b to
8553b10
Compare
kzar
approved these changes
Jan 7, 2025
sammacbeth
force-pushed
the
sam/colors-deprecated
branch
from
8553b10 to
23721cb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewer:
Description:
We get a sass depcration warning from
lightenanddarkenusage in theduckduckgo-colorslibrary. That library is now deprecated, so this PR removes it and copies across the variable declarations that we were using from there.See also https://app.asana.com/0/892838074342800/1209033116291734/f