Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set version_check_wait_retry_limit to 1 #3511

Merged
merged 1 commit into from
Oct 31, 2024
Merged

Set version_check_wait_retry_limit to 1 #3511

merged 1 commit into from
Oct 31, 2024

Conversation

ayoy
Copy link
Contributor

@ayoy ayoy commented Oct 31, 2024

Task/Issue URL: https://app.asana.com/0/1203301625297703/1208664774795332/f

Steps to test this PR:
Verify that this workflow passes

Definition of Done (Internal Only):

Copy Testing:

  • Use of correct apostrophes in new copy, ie rather than '

Orientation Testing:

  • Portrait
  • Landscape

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 15
  • iOS 16
  • iOS 17

Theme Testing:

  • Light theme
  • Dark theme

Internal references:

Software Engineering Expectations
Technical Design Template

@ayoy ayoy requested a review from afterxleep October 31, 2024 20:04
Copy link
Contributor

@samsymons samsymons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@ayoy ayoy merged commit 2d750c9 into main Oct 31, 2024
14 checks passed
@ayoy ayoy deleted the dominik/fix-promote branch October 31, 2024 20:06
samsymons added a commit that referenced this pull request Nov 4, 2024
# By Daniel Bernal (6) and others
# Via Daniel Bernal (3) and others
* main: (21 commits)
  Validate VPN errors before re-throwing them (#3513)
  Allowing users to delete suggestions on macOS (#3465)
  Update build number
  Update build number
  Bump rexml from 3.3.8 to 3.3.9 (#3495)
  Release 7.142.1-1 (#3525)
  Add a debouncer to NavBars animator (#3519)
  Release 7.143.0-1 (#3516)
  Update to subscription cookie (#3512)
  Bug Fix: Phishing Detection Dataset Discrepancies (#3469)
  Duckplayer New Tab + Refactor (#3491)
  Blind attempt to fix Omnibar-related crash (#3514)
  Fix VPN server info metadata (#3501)
  Set version_check_wait_retry_limit to 1 (#3511)
  BSK changes for macOS release note screen update (#3466)
  Onboarding Add to Dock Promo view (#3505)
  Update BSK with autofill 15.1.0 (#3507)
  Update tests to use new tagline (#3439)
  adding impression pixels for duckplayer in landscape mode (#3493)
  Update autoconsent to v10.17.0 (#3504)
  ...

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants