Skip to content

Add support for controlling sections visibility on HTML New Tab Page #14257

Add support for controlling sections visibility on HTML New Tab Page

Add support for controlling sections visibility on HTML New Tab Page #14257

Triggered via pull request November 19, 2024 08:48
Status Success
Total duration 11m 39s
Billable time 30m
Artifacts

pr.yml

on: pull_request
Matrix: Test
SwiftLint
42s
SwiftLint
Test Shell Scripts
19s
Test Shell Scripts
Make Release Build
7m 4s
Make Release Build
Verify autoconsent bundle
26s
Verify autoconsent bundle
ShellCheck
7s
ShellCheck
Private API Report  /  Update PR comment
3s
Private API Report / Update PR comment
Create Asana Task
0s
Create Asana Task
Close Asana Task
0s
Close Asana Task
Fit to window
Zoom out
Zoom in

Annotations

40 warnings and 1 notice
Verify autoconsent bundle
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-node@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Make Release Build
The following actions use a deprecated Node.js version and will be forced to run on node20: webfactory/[email protected]. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Make Release Build: LocalPackages/BuildToolPlugins/Plugins/InputFilesChecker/InputFilesChecker.swift#L166
extension declares a conformance of imported type 'File' to imported protocols 'Equatable', 'Hashable'; this will not behave correctly if the owners of 'PackagePlugin' introduce this conformance in the future
Make Release Build: LocalPackages/BuildToolPlugins/Plugins/InputFilesChecker/InputFilesChecker.swift#L166
extension declares a conformance of imported type 'File' to imported protocols 'Equatable', 'Hashable'; this will not behave correctly if the owners of 'PackagePlugin' introduce this conformance in the future
Make Release Build: LocalPackages/XPCHelper/Sources/XPCHelper/XPCServer.swift#L56
capture of 'newConnection' with non-sendable type 'NSXPCConnection' in a `@Sendable` closure; this is an error in the Swift 6 language mode
Make Release Build: LocalPackages/XPCHelper/Sources/XPCHelper/XPCServer.swift#L56
capture of 'newConnection' with non-sendable type 'NSXPCConnection' in a `@Sendable` closure; this is an error in the Swift 6 language mode
Make Release Build: LocalPackages/UDSHelper/Sources/UDSHelper/UDSServer.swift#L25
extension declares a conformance of imported type 'NWConnection' to imported protocols 'Hashable', 'Equatable'; this will not behave correctly if the owners of 'Network' introduce this conformance in the future
Make Release Build: LocalPackages/UDSHelper/Sources/UDSHelper/UDSServer.swift#L25
extension declares a conformance of imported type 'NWConnection' to imported protocols 'Hashable', 'Equatable'; this will not behave correctly if the owners of 'Network' introduce this conformance in the future
Make Release Build: LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionProxy/FlowManagers/UDPFlowManager.swift#L179
global actor 'UDPFlowActor'-isolated instance method 'hash(into:)' cannot be used to satisfy nonisolated protocol requirement; this is an error in the Swift 6 language mode
Make Release Build: LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionProxy/FlowManagers/UDPFlowManager.swift#L173
global actor 'UDPFlowActor'-isolated operator function '==' cannot be used to satisfy nonisolated protocol requirement; this is an error in the Swift 6 language mode
Make Release Build: LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionProxy/FlowManagers/UDPFlowManager.swift#L326
global actor 'UDPFlowActor'-isolated instance method 'hash(into:)' cannot be used to satisfy nonisolated protocol requirement; this is an error in the Swift 6 language mode
Make Release Build: LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionProxy/FlowManagers/UDPFlowManager.swift#L322
global actor 'UDPFlowActor'-isolated operator function '==' cannot be used to satisfy nonisolated protocol requirement; this is an error in the Swift 6 language mode
Test (Non-Sandbox)
The following actions use a deprecated Node.js version and will be forced to run on node20: webfactory/[email protected]. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Test (Non-Sandbox): LocalPackages/BuildToolPlugins/Plugins/InputFilesChecker/InputFilesChecker.swift#L166
extension declares a conformance of imported type 'File' to imported protocols 'Equatable', 'Hashable'; this will not behave correctly if the owners of 'PackagePlugin' introduce this conformance in the future
Test (Non-Sandbox): LocalPackages/BuildToolPlugins/Plugins/InputFilesChecker/InputFilesChecker.swift#L166
extension declares a conformance of imported type 'File' to imported protocols 'Equatable', 'Hashable'; this will not behave correctly if the owners of 'PackagePlugin' introduce this conformance in the future
Test (Non-Sandbox)
sandbox-test-tool isn't code signed but requires entitlements. It is not possible to add entitlements to a binary without signing it. (in target 'sandbox-test-tool' from project 'DuckDuckGo')
Test (Non-Sandbox): LocalPackages/BuildToolPlugins/Plugins/InputFilesChecker/InputFilesChecker.swift#L166
extension declares a conformance of imported type 'File' to imported protocols 'Equatable', 'Hashable'; this will not behave correctly if the owners of 'PackagePlugin' introduce this conformance in the future
Test (Non-Sandbox): LocalPackages/BuildToolPlugins/Plugins/InputFilesChecker/InputFilesChecker.swift#L166
extension declares a conformance of imported type 'File' to imported protocols 'Equatable', 'Hashable'; this will not behave correctly if the owners of 'PackagePlugin' introduce this conformance in the future
Test (Non-Sandbox): LocalPackages/XPCHelper/Sources/XPCHelper/XPCServer.swift#L56
capture of 'newConnection' with non-sendable type 'NSXPCConnection' in a `@Sendable` closure; this is an error in the Swift 6 language mode
Test (Non-Sandbox): LocalPackages/UDSHelper/Sources/UDSHelper/UDSServer.swift#L25
extension declares a conformance of imported type 'NWConnection' to imported protocols 'Hashable', 'Equatable'; this will not behave correctly if the owners of 'Network' introduce this conformance in the future
Test (Non-Sandbox): LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionProxy/FlowManagers/UDPFlowManager.swift#L179
global actor 'UDPFlowActor'-isolated instance method 'hash(into:)' cannot be used to satisfy nonisolated protocol requirement; this is an error in the Swift 6 language mode
Test (Non-Sandbox): LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionProxy/FlowManagers/UDPFlowManager.swift#L173
global actor 'UDPFlowActor'-isolated operator function '==' cannot be used to satisfy nonisolated protocol requirement; this is an error in the Swift 6 language mode
Test (Non-Sandbox): LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionProxy/FlowManagers/UDPFlowManager.swift#L326
global actor 'UDPFlowActor'-isolated instance method 'hash(into:)' cannot be used to satisfy nonisolated protocol requirement; this is an error in the Swift 6 language mode
Test (Non-Sandbox): LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionProxy/FlowManagers/UDPFlowManager.swift#L322
global actor 'UDPFlowActor'-isolated operator function '==' cannot be used to satisfy nonisolated protocol requirement; this is an error in the Swift 6 language mode
Test (Non-Sandbox): LocalPackages/SubscriptionUI/Sources/SubscriptionUI/DebugMenu/DebugPurchaseView.swift#L167
extension declares a conformance of imported type 'String' to imported protocol 'Identifiable'; this will not behave correctly if the owners of 'Swift' introduce this conformance in the future
Test (Sandbox)
The following actions use a deprecated Node.js version and will be forced to run on node20: webfactory/[email protected]. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Test (Sandbox): LocalPackages/BuildToolPlugins/Plugins/InputFilesChecker/InputFilesChecker.swift#L166
extension declares a conformance of imported type 'File' to imported protocols 'Equatable', 'Hashable'; this will not behave correctly if the owners of 'PackagePlugin' introduce this conformance in the future
Test (Sandbox): LocalPackages/BuildToolPlugins/Plugins/InputFilesChecker/InputFilesChecker.swift#L166
extension declares a conformance of imported type 'File' to imported protocols 'Equatable', 'Hashable'; this will not behave correctly if the owners of 'PackagePlugin' introduce this conformance in the future
Test (Sandbox)
sandbox-test-tool isn't code signed but requires entitlements. It is not possible to add entitlements to a binary without signing it. (in target 'sandbox-test-tool' from project 'DuckDuckGo')
Test (Sandbox): LocalPackages/BuildToolPlugins/Plugins/InputFilesChecker/InputFilesChecker.swift#L166
extension declares a conformance of imported type 'File' to imported protocols 'Equatable', 'Hashable'; this will not behave correctly if the owners of 'PackagePlugin' introduce this conformance in the future
Test (Sandbox): LocalPackages/BuildToolPlugins/Plugins/InputFilesChecker/InputFilesChecker.swift#L166
extension declares a conformance of imported type 'File' to imported protocols 'Equatable', 'Hashable'; this will not behave correctly if the owners of 'PackagePlugin' introduce this conformance in the future
Test (Sandbox): LocalPackages/XPCHelper/Sources/XPCHelper/XPCServer.swift#L56
capture of 'newConnection' with non-sendable type 'NSXPCConnection' in a `@Sendable` closure; this is an error in the Swift 6 language mode
Test (Sandbox): LocalPackages/XPCHelper/Sources/XPCHelper/XPCServer.swift#L56
capture of 'newConnection' with non-sendable type 'NSXPCConnection' in a `@Sendable` closure; this is an error in the Swift 6 language mode
Test (Sandbox): LocalPackages/UDSHelper/Sources/UDSHelper/UDSServer.swift#L25
extension declares a conformance of imported type 'NWConnection' to imported protocols 'Hashable', 'Equatable'; this will not behave correctly if the owners of 'Network' introduce this conformance in the future
Test (Sandbox): LocalPackages/UDSHelper/Sources/UDSHelper/UDSServer.swift#L25
extension declares a conformance of imported type 'NWConnection' to imported protocols 'Hashable', 'Equatable'; this will not behave correctly if the owners of 'Network' introduce this conformance in the future
Test (Sandbox): LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionProxy/FlowManagers/UDPFlowManager.swift#L179
global actor 'UDPFlowActor'-isolated instance method 'hash(into:)' cannot be used to satisfy nonisolated protocol requirement; this is an error in the Swift 6 language mode
Test (Sandbox): LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionProxy/FlowManagers/UDPFlowManager.swift#L173
global actor 'UDPFlowActor'-isolated operator function '==' cannot be used to satisfy nonisolated protocol requirement; this is an error in the Swift 6 language mode
Test (Sandbox)
Skipped Integration_Tests_App_Store.DownloadsIntegrationTests.testWhenLocalFile_downloadStartsAlwaysDisplayingSavePanel