Show VPN onboarding tips #14263
diegoreymendezpr.yml
on: pull_request
Matrix: Test
SwiftLint
43s
Test Shell Scripts
18s
Make Release Build
6m 38s
Verify autoconsent bundle
26s
ShellCheck
9s
Annotations
10 errors, 40 warnings, and 1 notice
|
SwiftLint:
LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionUI/Combine/CurrentValuePublisher.swift#L30
Colons should be next to the identifier when specifying a type and next to the key in dictionary literals (colon)
|
|
SwiftLint:
LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionUI/Combine/CurrentValuePublisher.swift#L1
Header comments should be consistent with project patterns (file_header)
|
|
SwiftLint:
LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionUI/Combine/CurrentValuePublisher.swift#L34
Lines should not have trailing whitespace (trailing_whitespace)
|
|
SwiftLint:
LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionUI/Combine/CurrentValuePublisher.swift#L35
Limit vertical whitespace to a single empty line; currently 2 (vertical_whitespace)
|
|
SwiftLint:
LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionUI/Views/TipViews/Model/VPNAutoconnectTip.swift#L1
Header comments should be consistent with project patterns (file_header)
|
|
SwiftLint:
LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionUI/Views/TipViews/Model/VPNGeoswitchingTip.swift#L1
Header comments should be consistent with project patterns (file_header)
|
|
SwiftLint:
LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionUI/Views/TunnelControllerView/TunnelControllerView.swift#L59
Prefer at least one space after slashes for comments (comment_spacing)
|
|
SwiftLint:
LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionUI/Views/TunnelControllerView/TunnelControllerView.swift#L60
Prefer at least one space after slashes for comments (comment_spacing)
|
|
SwiftLint:
LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionUI/Views/TunnelControllerView/TunnelControllerView.swift#L69
Prefer at least one space after slashes for comments (comment_spacing)
|
|
SwiftLint:
LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionUI/Views/TunnelControllerView/TunnelControllerView.swift#L70
Prefer at least one space after slashes for comments (comment_spacing)
|
|
Verify autoconsent bundle
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-node@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
Make Release Build
The following actions use a deprecated Node.js version and will be forced to run on node20: webfactory/[email protected]. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
Make Release Build:
LocalPackages/BuildToolPlugins/Plugins/InputFilesChecker/InputFilesChecker.swift#L166
extension declares a conformance of imported type 'File' to imported protocols 'Equatable', 'Hashable'; this will not behave correctly if the owners of 'PackagePlugin' introduce this conformance in the future
|
|
Make Release Build:
LocalPackages/BuildToolPlugins/Plugins/InputFilesChecker/InputFilesChecker.swift#L166
extension declares a conformance of imported type 'File' to imported protocols 'Equatable', 'Hashable'; this will not behave correctly if the owners of 'PackagePlugin' introduce this conformance in the future
|
|
Make Release Build:
LocalPackages/XPCHelper/Sources/XPCHelper/XPCServer.swift#L56
capture of 'newConnection' with non-sendable type 'NSXPCConnection' in a `@Sendable` closure; this is an error in the Swift 6 language mode
|
|
Make Release Build:
LocalPackages/XPCHelper/Sources/XPCHelper/XPCServer.swift#L56
capture of 'newConnection' with non-sendable type 'NSXPCConnection' in a `@Sendable` closure; this is an error in the Swift 6 language mode
|
|
Make Release Build:
LocalPackages/UDSHelper/Sources/UDSHelper/UDSServer.swift#L25
extension declares a conformance of imported type 'NWConnection' to imported protocols 'Hashable', 'Equatable'; this will not behave correctly if the owners of 'Network' introduce this conformance in the future
|
|
Make Release Build:
LocalPackages/UDSHelper/Sources/UDSHelper/UDSServer.swift#L25
extension declares a conformance of imported type 'NWConnection' to imported protocols 'Hashable', 'Equatable'; this will not behave correctly if the owners of 'Network' introduce this conformance in the future
|
|
Make Release Build:
LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionProxy/FlowManagers/UDPFlowManager.swift#L179
global actor 'UDPFlowActor'-isolated instance method 'hash(into:)' cannot be used to satisfy nonisolated protocol requirement; this is an error in the Swift 6 language mode
|
|
Make Release Build:
LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionProxy/FlowManagers/UDPFlowManager.swift#L173
global actor 'UDPFlowActor'-isolated operator function '==' cannot be used to satisfy nonisolated protocol requirement; this is an error in the Swift 6 language mode
|
|
Make Release Build:
LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionProxy/FlowManagers/UDPFlowManager.swift#L326
global actor 'UDPFlowActor'-isolated instance method 'hash(into:)' cannot be used to satisfy nonisolated protocol requirement; this is an error in the Swift 6 language mode
|
|
Make Release Build:
LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionProxy/FlowManagers/UDPFlowManager.swift#L322
global actor 'UDPFlowActor'-isolated operator function '==' cannot be used to satisfy nonisolated protocol requirement; this is an error in the Swift 6 language mode
|
|
Test (Non-Sandbox)
The following actions use a deprecated Node.js version and will be forced to run on node20: webfactory/[email protected]. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
Test (Non-Sandbox):
LocalPackages/BuildToolPlugins/Plugins/InputFilesChecker/InputFilesChecker.swift#L166
extension declares a conformance of imported type 'File' to imported protocols 'Equatable', 'Hashable'; this will not behave correctly if the owners of 'PackagePlugin' introduce this conformance in the future
|
|
Test (Non-Sandbox):
LocalPackages/BuildToolPlugins/Plugins/InputFilesChecker/InputFilesChecker.swift#L166
extension declares a conformance of imported type 'File' to imported protocols 'Equatable', 'Hashable'; this will not behave correctly if the owners of 'PackagePlugin' introduce this conformance in the future
|
|
Test (Non-Sandbox)
sandbox-test-tool isn't code signed but requires entitlements. It is not possible to add entitlements to a binary without signing it. (in target 'sandbox-test-tool' from project 'DuckDuckGo')
|
|
Test (Non-Sandbox):
LocalPackages/BuildToolPlugins/Plugins/InputFilesChecker/InputFilesChecker.swift#L166
extension declares a conformance of imported type 'File' to imported protocols 'Equatable', 'Hashable'; this will not behave correctly if the owners of 'PackagePlugin' introduce this conformance in the future
|
|
Test (Non-Sandbox):
LocalPackages/BuildToolPlugins/Plugins/InputFilesChecker/InputFilesChecker.swift#L166
extension declares a conformance of imported type 'File' to imported protocols 'Equatable', 'Hashable'; this will not behave correctly if the owners of 'PackagePlugin' introduce this conformance in the future
|
|
Test (Non-Sandbox):
LocalPackages/XPCHelper/Sources/XPCHelper/XPCServer.swift#L56
capture of 'newConnection' with non-sendable type 'NSXPCConnection' in a `@Sendable` closure; this is an error in the Swift 6 language mode
|
|
Test (Non-Sandbox):
LocalPackages/UDSHelper/Sources/UDSHelper/UDSServer.swift#L25
extension declares a conformance of imported type 'NWConnection' to imported protocols 'Hashable', 'Equatable'; this will not behave correctly if the owners of 'Network' introduce this conformance in the future
|
|
Test (Non-Sandbox):
LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionProxy/FlowManagers/UDPFlowManager.swift#L179
global actor 'UDPFlowActor'-isolated instance method 'hash(into:)' cannot be used to satisfy nonisolated protocol requirement; this is an error in the Swift 6 language mode
|
|
Test (Non-Sandbox):
LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionProxy/FlowManagers/UDPFlowManager.swift#L173
global actor 'UDPFlowActor'-isolated operator function '==' cannot be used to satisfy nonisolated protocol requirement; this is an error in the Swift 6 language mode
|
|
Test (Non-Sandbox):
LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionProxy/FlowManagers/UDPFlowManager.swift#L326
global actor 'UDPFlowActor'-isolated instance method 'hash(into:)' cannot be used to satisfy nonisolated protocol requirement; this is an error in the Swift 6 language mode
|
|
Test (Non-Sandbox):
LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionProxy/FlowManagers/UDPFlowManager.swift#L322
global actor 'UDPFlowActor'-isolated operator function '==' cannot be used to satisfy nonisolated protocol requirement; this is an error in the Swift 6 language mode
|
|
Test (Non-Sandbox):
LocalPackages/SubscriptionUI/Sources/SubscriptionUI/DebugMenu/DebugPurchaseView.swift#L167
extension declares a conformance of imported type 'String' to imported protocol 'Identifiable'; this will not behave correctly if the owners of 'Swift' introduce this conformance in the future
|
|
Test (Non-Sandbox):
DerivedData/Build/Products/CI/GRDB.framework/Headers/GRDB.h#L11
umbrella header for module 'GRDB' does not include header 'sqlite3.h'
|
|
Test (Sandbox)
The following actions use a deprecated Node.js version and will be forced to run on node20: webfactory/[email protected]. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
Test (Sandbox):
LocalPackages/BuildToolPlugins/Plugins/InputFilesChecker/InputFilesChecker.swift#L166
extension declares a conformance of imported type 'File' to imported protocols 'Equatable', 'Hashable'; this will not behave correctly if the owners of 'PackagePlugin' introduce this conformance in the future
|
|
Test (Sandbox):
LocalPackages/BuildToolPlugins/Plugins/InputFilesChecker/InputFilesChecker.swift#L166
extension declares a conformance of imported type 'File' to imported protocols 'Equatable', 'Hashable'; this will not behave correctly if the owners of 'PackagePlugin' introduce this conformance in the future
|
|
Test (Sandbox)
sandbox-test-tool isn't code signed but requires entitlements. It is not possible to add entitlements to a binary without signing it. (in target 'sandbox-test-tool' from project 'DuckDuckGo')
|
|
Test (Sandbox):
LocalPackages/BuildToolPlugins/Plugins/InputFilesChecker/InputFilesChecker.swift#L166
extension declares a conformance of imported type 'File' to imported protocols 'Equatable', 'Hashable'; this will not behave correctly if the owners of 'PackagePlugin' introduce this conformance in the future
|
|
Test (Sandbox):
LocalPackages/BuildToolPlugins/Plugins/InputFilesChecker/InputFilesChecker.swift#L166
extension declares a conformance of imported type 'File' to imported protocols 'Equatable', 'Hashable'; this will not behave correctly if the owners of 'PackagePlugin' introduce this conformance in the future
|
|
Test (Sandbox):
LocalPackages/XPCHelper/Sources/XPCHelper/XPCServer.swift#L56
capture of 'newConnection' with non-sendable type 'NSXPCConnection' in a `@Sendable` closure; this is an error in the Swift 6 language mode
|
|
Test (Sandbox):
LocalPackages/XPCHelper/Sources/XPCHelper/XPCServer.swift#L56
capture of 'newConnection' with non-sendable type 'NSXPCConnection' in a `@Sendable` closure; this is an error in the Swift 6 language mode
|
|
Test (Sandbox):
LocalPackages/UDSHelper/Sources/UDSHelper/UDSServer.swift#L25
extension declares a conformance of imported type 'NWConnection' to imported protocols 'Hashable', 'Equatable'; this will not behave correctly if the owners of 'Network' introduce this conformance in the future
|
|
Test (Sandbox):
LocalPackages/UDSHelper/Sources/UDSHelper/UDSServer.swift#L25
extension declares a conformance of imported type 'NWConnection' to imported protocols 'Hashable', 'Equatable'; this will not behave correctly if the owners of 'Network' introduce this conformance in the future
|
|
Test (Sandbox):
LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionProxy/FlowManagers/UDPFlowManager.swift#L179
global actor 'UDPFlowActor'-isolated instance method 'hash(into:)' cannot be used to satisfy nonisolated protocol requirement; this is an error in the Swift 6 language mode
|
|
Test (Sandbox):
LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionProxy/FlowManagers/UDPFlowManager.swift#L173
global actor 'UDPFlowActor'-isolated operator function '==' cannot be used to satisfy nonisolated protocol requirement; this is an error in the Swift 6 language mode
|
|
Test (Sandbox):
LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionProxy/FlowManagers/UDPFlowManager.swift#L326
global actor 'UDPFlowActor'-isolated instance method 'hash(into:)' cannot be used to satisfy nonisolated protocol requirement; this is an error in the Swift 6 language mode
|
|
Test (Sandbox):
LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionProxy/FlowManagers/UDPFlowManager.swift#L322
global actor 'UDPFlowActor'-isolated operator function '==' cannot be used to satisfy nonisolated protocol requirement; this is an error in the Swift 6 language mode
|
|
Test (Sandbox)
Skipped Integration_Tests_App_Store.DownloadsIntegrationTests.testWhenLocalFile_downloadStartsAlwaysDisplayingSavePanel
|