Skip to content

Commit

Permalink
macOS 13/14 UI test compilation fix (#3569)
Browse files Browse the repository at this point in the history
Task/Issue URL: https://app.asana.com/0/1201037661562251/1208772745284327/f
Tech Design URL:
CC:

Description:

This PR fixes UI test compilation on macOS 13/14.

The issue was that the UI test suite was linking BSK, which causes Xcode to then compile it - but, we can't allow it to do that since GRDB was built with a newer version of Xcode.
  • Loading branch information
samsymons committed Nov 19, 2024
1 parent 8602595 commit 632c5b2
Showing 1 changed file with 0 additions and 8 deletions.
8 changes: 0 additions & 8 deletions DuckDuckGo.xcodeproj/project.pbxproj
Original file line number Diff line number Diff line change
Expand Up @@ -3013,7 +3013,6 @@
EA8AE76A279FBDB20078943E /* ClickToLoadTDSTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = EA8AE769279FBDB20078943E /* ClickToLoadTDSTests.swift */; };
EE02D41A2BB4609900DBE6B3 /* UITests.swift in Sources */ = {isa = PBXBuildFile; fileRef = EE02D4192BB4609900DBE6B3 /* UITests.swift */; };
EE02D41C2BB460A600DBE6B3 /* BrowsingHistoryTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = EE02D41B2BB460A600DBE6B3 /* BrowsingHistoryTests.swift */; };
EE02D4202BB460C000DBE6B3 /* BrowserServicesKit in Frameworks */ = {isa = PBXBuildFile; productRef = EE02D41F2BB460C000DBE6B3 /* BrowserServicesKit */; };
EE02D4222BB4611A00DBE6B3 /* TestsURLExtension.swift in Sources */ = {isa = PBXBuildFile; fileRef = B6EC37FB29B83E99001ACE79 /* TestsURLExtension.swift */; };
EE0429E02BA31D2F009EB20F /* FindInPageTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = EE0429DF2BA31D2F009EB20F /* FindInPageTests.swift */; };
EE098E772C8EDE2C009EBA7F /* AutofillCredentialsImportManager.swift in Sources */ = {isa = PBXBuildFile; fileRef = EE098E762C8EDE2C009EBA7F /* AutofillCredentialsImportManager.swift */; };
Expand Down Expand Up @@ -5133,7 +5132,6 @@
isa = PBXFrameworksBuildPhase;
buildActionMask = 2147483647;
files = (
EE02D4202BB460C000DBE6B3 /* BrowserServicesKit in Frameworks */,
9D9DE57F2C63B64F00D20B15 /* AppKitExtensions in Frameworks */,
B64E42872B908501006C1346 /* SnapshotTesting in Frameworks */,
);
Expand Down Expand Up @@ -10116,7 +10114,6 @@
name = "UI Tests";
packageProductDependencies = (
B65CD8D22B316E1700A595BB /* SnapshotTesting */,
EE02D41F2BB460C000DBE6B3 /* BrowserServicesKit */,
9D9DE57E2C63B64F00D20B15 /* AppKitExtensions */,
);
productName = "UI Tests";
Expand Down Expand Up @@ -15949,11 +15946,6 @@
package = 3FFD51CF7C19ACBDB9687474 /* XCRemoteSwiftPackageReference "BrowserServicesKit" */;
productName = Subscription;
};
EE02D41F2BB460C000DBE6B3 /* BrowserServicesKit */ = {
isa = XCSwiftPackageProductDependency;
package = 9807F643278CA16F00E1547B /* XCRemoteSwiftPackageReference "BrowserServicesKit" */;
productName = BrowserServicesKit;
};
EE2F9C5A2B90F2FF00D45FC9 /* Subscription */ = {
isa = XCSwiftPackageProductDependency;
package = 9807F643278CA16F00E1547B /* XCRemoteSwiftPackageReference "BrowserServicesKit" */;
Expand Down

0 comments on commit 632c5b2

Please sign in to comment.