Add expectation when checking email text field value #3572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alessandroboron
approved these changes
Nov 19, 2024
There was a problem hiding this comment.
Thank for the fix @jotaemepereira.
We should probably start building functions that we can re-use at some point because it’s pretty common to wait for XCUIElement to appear or have a certain value. In that way we can re-use them across the tests.
Good call. I will move things to utilities in my current project. |
samsymons
added a commit
that referenced
this pull request
Nov 21, 2024
…g-error # By Anka (5) and others # Via GitHub (5) and Dominik Kapusta (1) * main: (28 commits) Add attemptCount and maxAttempts to broker config (#3533) Hide continue setup cards after 1 week (#3471) Add expectation when checking email text field value (#3572) [macos] adding support for message bridge (#3558) Update PIR test runner (#3570) Add support for controlling sections visibility on HTML New Tab Page (#3551) Bump version to 1.115.0 (311) macOS 13/14 UI test compilation fix (#3569) macOS 13/14 UI test compilation fix (#3569) Fix bug where bookmarks bar prompt does not hide bar (#3553) Add OS version to download fail pixel (#3568) Remove get_tasks_in_last_internal_release (#3566) Bump version to 1.115.0 (310) Update skip-release check Update fastlane plugin to 0.11.6 Bump ddg-apple-automation version for bugfix (#3565) PIR E2E tests GitHub actions (#3528) Update autoconsent to v11.5.0 (#3561) Bump version to 1.115.0 (309) Set marketing version to 1.115.0 ... # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1204006570077678/1208793837278290/f
Tech Design URL:
CC:
Description:
The
testCrendentialsAreAutoFilledInFireWindowsfailed on macOS 15.Checking the logs, the problem was that there was a slight delay when the autofill credentials email is tapped and when it is loaded into the web view text field; given that we do not wait and check immediately, it could sometimes fail.
I’ve added an expectation, so we will now wait for the email to appear.
Steps to test this PR:
testCrendentialsAreAutoFilledInFireWindowstestDefinition of Done:
—
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation