Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an issue that cause compilation failure #3587

Merged
merged 1 commit into from
Nov 23, 2024

Conversation

alessandroboron
Copy link
Contributor

@alessandroboron alessandroboron commented Nov 22, 2024

Task/Issue URL: https://app.asana.com/0/1201037661562251/1208822723600157/f

Description:

Fix compilation issue for Xcode 15 due to usage of [@retroactive](https://github.com/swiftlang/swift-evolution/blob/main/proposals/0364-retroactive-conformance-warning.md#source-compatibility) keyword.

Silence the warning by fully qualifying the protocol name with module name.

Optional E2E tests:

  • Run PIR E2E tests
    Check this to run the Personal Information Removal end to end tests. If updating CCF, or any PIR related code, tick this.

Steps to test this PR:

  1. Ensure Xcode doesn’t show a warning for extension File: Swift.Equatable, Swift.Hashable

Definition of Done:


Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

Copy link
Collaborator

@ayoy ayoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great find with the backwards-compatible solution! 💪

@ayoy ayoy merged commit c934664 into main Nov 23, 2024
25 of 27 checks passed
@ayoy ayoy deleted the alessandro/fix-xcode15-compilation branch November 23, 2024 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants