Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Malware protection 6: Malware integration #3604

Open
wants to merge 1 commit into
base: alex/malware-protection-5
Choose a base branch
from

Conversation

mallexxx
Copy link
Collaborator

@mallexxx mallexxx commented Nov 27, 2024

Task/Issue URL: https://app.asana.com/0/481882893211075/1208033567421351/f
BSK PR: duckduckgo/BrowserServicesKit#1099

Description:

  • add .malware threat and special page types

Optional E2E tests:

  • Run PIR E2E tests
    Check this to run the Personal Information Removal end to end tests. If updating CCF, or any PIR related code, tick this.

Steps to test this PR:
0.1. Check out https://github.com/duckduckgo/content-scope-scripts/tree/pr-releases/pr-1268 and npm install; npm run build; add reference to the project
0.2. Check out https://github.com/duckduckgo/privacy-dashboard/tree/pr-releases/pr-250 and npm install; npm run build; add reference to the project

  • or use the Review build
  1. Validate http://privacy-test-pages.site/security/badware/malware.html detects malware
  2. Validate http://privacy-test-pages.site/security/badware/phishing.html detects phishing
  3. Validate Privacy Dashboard displaying status on overridden navigation
  4. Validate Help/Report links (not ready yet)

Definition of Done:


Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant