-
-
Notifications
You must be signed in to change notification settings - Fork 474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add optional #170
Add optional #170
Conversation
Wrapper container with easy to understand helper methods
cde15dc
to
911bde9
Compare
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #170 +/- ##
==========================================
- Coverage 83.73% 80.21% -3.53%
==========================================
Files 46 64 +18
Lines 3621 7116 +3495
==========================================
+ Hits 3032 5708 +2676
- Misses 393 1079 +686
- Partials 196 329 +133 ☔ View full report in Codecov by Sentry. |
@donutloop, okay, I will add the documentation. |
@donutloop Hi donutloop. there is To fix it. Can we change field |
@duke-git Yes, I concur that the optional container is meant to be circulated. Moving forward, I'll make sure to execute the vet command prior to submitting a PR. Normally, I adhere to this practice, is this vet check already part of the code pipeline? If not, we can setup a code action in GitHub for it. Was already late here |
@donutloop, now this vet check isn't part of the code pipeline. It's my local editor check. Yeah, we can add a vet check step to the github action file like this:, if ok, I will add it now. |
Wrapper container with easy to understand helper methods.
Note: Documentation is missing
@duke-git Please review