Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional #170

Merged
merged 4 commits into from
Feb 19, 2024
Merged

Add optional #170

merged 4 commits into from
Feb 19, 2024

Conversation

donutloop
Copy link
Collaborator

Wrapper container with easy to understand helper methods.

Note: Documentation is missing

@duke-git Please review

Wrapper container with easy to understand helper methods
@codecov-commenter
Copy link

codecov-commenter commented Feb 18, 2024

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (3d7600a) 83.73% compared to head (16b5b4a) 80.21%.
Report is 706 commits behind head on main.

Files Patch % Lines
internal/assert.go 0.00% 6 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #170      +/-   ##
==========================================
- Coverage   83.73%   80.21%   -3.53%     
==========================================
  Files          46       64      +18     
  Lines        3621     7116    +3495     
==========================================
+ Hits         3032     5708    +2676     
- Misses        393     1079     +686     
- Partials      196      329     +133     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@duke-git
Copy link
Owner

Wrapper container with easy to understand helper methods.

Note: Documentation is missing

@duke-git Please review

@donutloop, okay, I will add the documentation.

@duke-git duke-git merged commit bf4b2b5 into duke-git:main Feb 19, 2024
2 of 3 checks passed
@duke-git
Copy link
Owner

@donutloop Hi donutloop. there is copylocks warning in Optional struct methods(see blow picture),
image

To fix it. Can we change field mu to *syncRWMutex, and init mu in construct methods(Empty, Of, OfNullable)?, see blow picture, I have updated it in v2 branch. What do you think of it?

image

@donutloop
Copy link
Collaborator Author

donutloop commented Feb 19, 2024

@duke-git Yes, I concur that the optional container is meant to be circulated. Moving forward, I'll make sure to execute the vet command prior to submitting a PR. Normally, I adhere to this practice, is this vet check already part of the code pipeline? If not, we can setup a code action in GitHub for it.

Was already late here

@duke-git
Copy link
Owner

@donutloop, now this vet check isn't part of the code pipeline. It's my local editor check. Yeah, we can add a vet check step to the github action file like this:, if ok, I will add it now.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants