Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another attempt at fixing #1269
I still couldn't reproduce the issue, but here is my best guess:
Some PHP extensions probably access environment variables when starting the main thread. In a past PR, we changed it so all environment is accessed via go
frankenphp/frankenphp.c
Line 777 in 0fc6ccc
So we need to make sure the
phpThreads
slice is initialized before starting the main thread, so it can pin to the first phpThread (threadIndex on the main thread defaults to 0)