[feat] Code change for compile on windows. Needs to modify php-src. #1286
+241
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dunglas
reviewed
Dec 22, 2024
frankenphp.c
Outdated
Comment on lines
31
to
33
| #elif defined(__MINGW64__) | ||
| #include <pthread.h> | ||
| #endif |
There was a problem hiding this comment.
Suggested change
| #elif defined(__MINGW64__) | |
| #include <pthread.h> | |
| #endif |
pthread.h is always included (line 20)
frankenphp.go
Outdated
Comment on lines
18
to
21
| // #cgo linux CFLAGS: -Wall -Werror | ||
| // #cgo darwin CFLAGS: -Wall -Werror | ||
| // #cgo openbsd CFLAGS: -Wall -Werror | ||
| // #cgo freebsd CFLAGS: -Wall -Werror |
There was a problem hiding this comment.
Suggested change
| // #cgo linux CFLAGS: -Wall -Werror | |
| // #cgo darwin CFLAGS: -Wall -Werror | |
| // #cgo openbsd CFLAGS: -Wall -Werror | |
| // #cgo freebsd CFLAGS: -Wall -Werror | |
| // #cgo unix CFLAGS: -Wall -Werror |
Should work
|
Thanks for your comments. I've take them and added the compilation documentation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.