fix: random crash when starting or reloading #394
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ugly fix for crashes reported in laravel/octane#764.
test-reload.sh
is a reproducer. The crash produces the following stack trace (collected using lldb on Mac):It looks like there is a race condition during the startup of https://github.com/Pithikos/C-Thread-Pool, this sleep is a workaround to be sure that threads are ready before sending them work.
A better fix should be possible, but I don't understand why the threads aren't ready while there is code in the library for that.