CardDAV support for owncloud / sabredav plus external IMAP provider #83

arved · 2013-07-11T19:41:06Z

redone to not replace the original carddav.php, but to use as an alternative

Based on the CardDAV code of ziirish there is an working CardDAV backend for owncloud / SabreDAV.
(see issue #80 / #76 / #47/ #71 )

to support my szenario there is a need to support external email provider with complete email address as loginname
Owncloud, can not handle Email adresses as usernamens. To use PHP-Push-2 in this requirement I've added some code

to use IMAP of 3rd party providers with, email address as login name

use 3rd party IMAP privider with email address as login name

changes to work with ownCloud on qnap agains Samsung Galaxy Note2

updated to work with owncloud 5.0.7 on qnap 4.0.1 with Samsung Galaxy Note 2

updated to work with owncloud 5.0.7 on qnap 4.0.1 with Samsung Galaxy Note 2 Signed-off-by: arved <[email protected]>

Changes on device shoud now be replicated correctly

because of $type = strtolower(array_shift($fieldparts)); $types can never be "CATEGORIES"

added code by justbrain slightly adopted to the structure of the section to make things more readable

Using built in function to create FN, found in utils.php to use the FILEAS_ORDER Setting in config.php Introducing a new Switch to always override FN according to the Setting in config.php

Android and ownCloud uses this format by default if you are creating a new contact.

See Readme.md

Changed URLs and names.

exiva · 2013-07-21T22:59:06Z

Yep, was fixed in efb7729

changed line 1303 to 'NOTE:'."\n "

arved · 2013-07-22T06:03:58Z

the fix you provided is making problems in my environment. So I reveted the changes you made, and changed line 1303 to $data .= 'NOTE:'."\n " . str_replace('\n' , '\n ' , $message->body). "\n ";
this should solve the issue

arved · 2013-07-22T18:09:48Z

@justbrain will check and test it

exiva · 2013-07-22T20:14:13Z

According to rfc2426 there should not be a \n after NOTE:, and commas and semicolons should be escaped. Though, I haven't tried to see if this breaks in this implementation.

Type example:

    NOTE:This fax number is operational 0800 to 1715
      EST\, Mon-Fri.

arved · 2013-07-23T12:14:21Z

@exiva ...and the colon must be escaped in all content fields. this is valid for all content. Obviously these special caracters are needed in some structured or multi valued fields, like CATEGORIES, ADR, ORG.
so I have to add more code an do much more testing on it. this may take some time....

to be honest I did some reverse engeneering on ownclouds CardDAV / vCard behavior, because this did not behave like described in the rfcs. There are so many differenz CardDAV / vCard implementations out there, which behave slightly different, I not sure if anyone can be covered ...

I think it would be better to continue this here: https://github.com/arved/PHP-Push-2-owncloud.
@exiva can you open an issue ?

adding addition of ;:, with escape character (\) (line 1304)for baking vCard NOTE. Removal of esc characters in Body for sync back via AS (line 1173)

exiva · 2013-07-23T19:31:42Z

I Haven't tried the new changes, but there's a typo that breaks address support.

carddav_oc5.php line 1265.
if((!empty($message->$adri)) && ($messabge->$adri != '')){

should be

if((!empty($message->$adri)) && ($message->$adri != '')){

Also, can you talk about why there's a cachesync folder? This seems to break syncing on my Windows Phone (I don't have another device to test.) and duplicate contacts when enabled. When I disable it and leave it to the script can't write to the directory it works fine. I don't see it in the original carddav either.

some additional fixes

arved · 2013-07-23T19:52:24Z

this folder is because of a missing implemtation of "sync-collection" in sabredav
more on this here fmbiete/Z-Push-contrib#1
this carddav implementation is based on the code of ziirish ...

…ML mails Tested for 2 Weeks agains qnap 4.0.2 without any warranty you will loose data

…E_OC5

dupondje · 2013-10-11T20:59:20Z

Hi

First of all thank you for your work on this.
But some remarks.

Why did you choose to add a CardDAV backend, and not fix/update the current CardDAV backend? I do not like we have 2 backends for CardDAV. We should make 1 good, which works with all CardDAV servers.
I prefer not to do ANY changes to the existing Z-Push code. If it would be needed, please let me know. Then i'll commit a change on Z-Push itself :) If we start adding patches on Z-Push code, it will get unmaintainable to patch it every time.
Would it eventually be possible to create 1 pull request with just the addition of the CardDAV backend + Changes? Cause now i'm losing myself a bit in all the commits you did.

If this can be fixed, i'll be happy to merge your commit!

arved · 2013-10-11T22:23:37Z

Hi,
the main issue is, sabreDAV / ownCloud does not support all carddav commands defined in the standard. So from my point of view there is a good backend - the original one. But for this special case there is a need to work around the missing / non-standard parts of sabreDAV / owncloud. This is the reason to make an additional one, hoping one day sabreDAV will fully support the standard and my one will be obsolete.
The carddav backend for sabreDAV is modular, so there are two files and a few additional lines in the config files
You're right the IMAP addtion should be handled seperatly. In fact this is a really small thing.
Starting next week I will rework the request, to just contain the additional CardDAV backend for owncloud / SabreDAV

dupondje · 2013-10-11T22:43:53Z

Hi

I guess there can be a way to detect if its sabredav/owncloud, and then use some workarounds in the same carddav class? Cause now we would have alot of duplicate code as most of the carddav code can just be used for both.

arved · 2013-10-11T23:49:42Z

Hi,
probably there is a way to do so, but I'm not a progammer, this is my frist expericence with php. Before - few years ago - I've just did some VBScript. So this is beyoned my skills.
Maybe a real php programmer can help us out?

nafets227 · 2013-10-12T22:50:01Z

what about doing it in two steps:

submit the oc5 backend as additional one
rework to unify oc5 and normal backend, maybe with one or two
config-switches.

I can try this; but since my time is limited I cannot promise...

remove "missing cahrs in Email" problem for non standard compliant devices

arved · 2013-10-13T05:49:14Z

within the nex few daxs I will address nafets227 first point by reworking an resubmitting a singe push request.

arved · 2013-10-14T07:31:27Z

Hi, I'm struggeling with the usage of github :-(
the owncloud carddav backend consists of two additional files (\PHP-Push-2-owncloud\backend\carddav_oc5.php and \PHP-Push-2-owncloud\include\carddav_iOC5.php) along with modification in two config.php files (PHP-Push-2-owncloud\config.php and PHP-Push-2-owncloud\backend\combined\config.php).

But I have no idea how to realize a pull request for only this without loosing everything else.

Can someone help me out?

nafets227 · 2013-10-14T18:53:27Z

Hi,

I have no clean solution (maybe someone else), but to workaround this I
would:

create a branch in original owncloud repo
checkout this branch to a local filesystem
manually copy the three files into the local filesystem or change
existing files to the new "should" state
!!! this means losing all history of the changes you have in your
repo PHP-Push-2-owncloud. But I know no other way !!!
add files to git
commit
push to upstream

if it helps I can try this for you and you can check the results before
pushing to the master branch where dupondje has to accept.

arved · 2013-10-15T07:04:02Z

replaced by new pull request #91 with only the changes for sabeDAV / CardDAV / owncloud

arved and others added 30 commits June 30, 2013 18:08

Update config.php

ef41b24

to use IMAP of 3rd party providers with, email address as login name

Update imap.php

f0ae548

use 3rd party IMAP privider with email address as login name

Create qoc_carddav.php

a565169

changes to work with ownCloud on qnap agains Samsung Galaxy Note2

Update config.php

31b95f4

updated to work with owncloud 5.0.7 on qnap 4.0.1 with Samsung Galaxy Note 2

Update carddav.php

03edbcf

updated to work with owncloud 5.0.7 on qnap 4.0.1 with Samsung Galaxy Note 2 Signed-off-by: arved <[email protected]>

Update README.md

5f47f21

Update carddav.php

82bdf80

Changes on device shoud now be replicated correctly

Update carddav.php

2c0da57

Update carddav.php

2bd756c

changed "CATEGORIES" to "categories"

4334f21

because of $type = strtolower(array_shift($fieldparts)); $types can never be "CATEGORIES"

Update carddav.php

2009a4c

added code by justbrain slightly adopted to the structure of the section to make things more readable

Update carddav.php

952d842

\n doesn't work in single quotes

0f06122

Code design changes on carddav.php

20214d0

Not every person has a middle name

74e97a7

Update carddav.php

813f94f

Using built in function to create FN, found in utils.php to use the FILEAS_ORDER Setting in config.php Introducing a new Switch to always override FN according to the Setting in config.php

Update config.php

d7bfcbb

Using built in function to create FN, found in utils.php to use the FILEAS_ORDER Setting in config.php Introducing a new Switch to always override FN according to the Setting in config.php

BuildFileAs is a method of Utils, not a global fn

4c4c149

Changed FILEAS_ORDER to SYNC_FILEAS_FIRSTLAST

67bc3db

Android and ownCloud uses this format by default if you are creating a new contact.

Delete config.inc.php

ed7ce6d

Rename config.php to config.inc.php

304d02d

Restored the config.php from PHP-Push-2 (original from Z-Push)

a782066

See Readme.md

Delete config.inc.php

8b9f328

Rename config.php to config.inc.php

06c9089

Restored the config.php from PHP-Push-2 (original from Z-Push)

bababa0

Update README.md

753f5dd

Changed URLs and names.

changed things to act as module in PHP-push-2

5b8e6f7

Check on vars

8771cd0

Update carddav_oc5.php

12675e3

Rebase Z-Push 2.0.7

b31a3c2

Update carddav_oc5.php

6a769e6

Update carddav_oc5.php

a9d5239

changed line 1303 to 'NOTE:'."\n "

arved added 4 commits July 23, 2013 16:15

add escaping chars to NOTE

03bb1c4

adding addition of ;:, with escape character (\) (line 1304)for baking vCard NOTE. Removal of esc characters in Body for sync back via AS (line 1173)

Update carddav_oc5.php

3ab6475

Update carddav_oc5.php

0d672ef

escape char to notes

1f5b503

adding addition of ;:, with escape character (\) (line 1304)for baking vCard NOTE. Removal of esc characters in Body for sync back via AS (line 1173)

using internal escape / unescape function for note

0ca6217

some additional fixes

arved and others added 3 commits August 29, 2013 10:17

reworked and removed unneeded code switeched to AS v12.0 to enable HT…

02dbfd0

…ML mails Tested for 2 Weeks agains qnap 4.0.2 without any warranty you will loose data

add readme-owncloud

df45ebf

corrected FILEAS_ALLWAYSOVERRIDE_OC5 to CARDDAV_FILEAS_ALLWAYSOVERRID…

162c164

…E_OC5

Update carddav_oc5.php

f3016a5

remove "missing cahrs in Email" problem for non standard compliant devices

Update carddav_oc5.php

60f36c5

nafets227 mentioned this pull request Oct 13, 2013

Upgrade to Z-Push 2.1 #89

Open

arved closed this Oct 15, 2013

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CardDAV support for owncloud / sabredav plus external IMAP provider #83

CardDAV support for owncloud / sabredav plus external IMAP provider #83

arved commented Jul 11, 2013

exiva commented Jul 21, 2013

arved commented Jul 22, 2013

arved commented Jul 22, 2013

exiva commented Jul 22, 2013

arved commented Jul 23, 2013

exiva commented Jul 23, 2013

arved commented Jul 23, 2013

dupondje commented Oct 11, 2013

arved commented Oct 11, 2013

dupondje commented Oct 11, 2013

arved commented Oct 11, 2013

nafets227 commented Oct 12, 2013

arved commented Oct 13, 2013

arved commented Oct 14, 2013

nafets227 commented Oct 14, 2013

arved commented Oct 15, 2013

CardDAV support for owncloud / sabredav plus external IMAP provider #83

CardDAV support for owncloud / sabredav plus external IMAP provider #83

Conversation

arved commented Jul 11, 2013

exiva commented Jul 21, 2013

arved commented Jul 22, 2013

arved commented Jul 22, 2013

exiva commented Jul 22, 2013

arved commented Jul 23, 2013

exiva commented Jul 23, 2013

arved commented Jul 23, 2013

dupondje commented Oct 11, 2013

arved commented Oct 11, 2013

dupondje commented Oct 11, 2013

arved commented Oct 11, 2013

nafets227 commented Oct 12, 2013

arved commented Oct 13, 2013

arved commented Oct 14, 2013

nafets227 commented Oct 14, 2013

arved commented Oct 15, 2013