Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove separate point validity checks #13

Merged
merged 1 commit into from
Apr 24, 2024
Merged

Remove separate point validity checks #13

merged 1 commit into from
Apr 24, 2024

Conversation

moCello
Copy link
Member

@moCello moCello commented Apr 23, 2024 •
edited
Loading

There is no need to duplicate the separate checks for is_identity, is_on_curve and is_torsion_free. A singular is_valid should be enough.

@moCello moCello force-pushed the mocello/improve_validity_check branch from aac2ae1 to 8b5c89f Compare April 23, 2024 20:16
@moCello moCello force-pushed the mocello/improve_validity_check branch from 8b5c89f to 5bd70e2 Compare April 24, 2024 08:07
ureeves
ureeves approved these changes Apr 24, 2024
View reviewed changes
Copy link
Member

@ureeves ureeves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@moCello moCello merged commit 4047c68 into main Apr 24, 2024
5 checks passed
@moCello moCello deleted the mocello/improve_validity_check branch April 24, 2024 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ureeves ureeves ureeves approved these changes

@HDauven HDauven Awaiting requested review from HDauven

@xevisalle xevisalle Awaiting requested review from xevisalle

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@moCello @ureeves