Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TXs should be prioritized based on a well-defined strategy #1240

Open
autholykos opened this issue Jan 13, 2022 · 2 comments
Open

TXs should be prioritized based on a well-defined strategy #1240

autholykos opened this issue Jan 13, 2022 · 2 comments
Labels
area:p2p issues related to kadcast, peer, gossip mark:testnet

Comments

@autholykos
Copy link
Member

autholykos commented Jan 13, 2022

Describe what you want implemented
A strategy for mempool prioritization based on transaction fees should be introduced. This also involves a (probably custom made) rate limiter that would prioritize transactions with higher fees

Describe "Why" this is needed
We want to give precedence to some transactions based on a good strategy. Moreover, since the introduction of rate limiting, there is an opportunity for propagation of transactions with higher fees first

Describe alternatives you've considered

  • Tipping the block generators
  • Prioritize based on higher gas price
  • Calculate the range of the previously spent tx divided per contract

Wrt the rate limiting we can do nothing and delegate prioritization of transaction execution to the recipient queue. It is actually unclear which approach is the most desirable.

Additional context
Originally posted by @autholykos in #1238 (comment)

@autholykos autholykos added area:p2p issues related to kadcast, peer, gossip mark:testnet labels Jan 13, 2022
@autholykos autholykos changed the title Rate limiter should prioritise TXs with higher fees TXs should be prioritized based on a well-defined strategy Mar 2, 2022
herr-seppia added a commit that referenced this issue Mar 7, 2022
- `Fee()` returns GasPrice instead of GasLimit
- `Fee()` is used to RangeSort txs extraction

See also dusk-network/rusk#605
See also #1240
@autholykos autholykos added mark:next tasks playing a role in the strategic plans mark:testnet and removed mark:testnet mark:next tasks playing a role in the strategic plans labels Mar 25, 2022
@autholykos
Copy link
Member Author

The strategy should also keep into consideration eventual flooding attacks based on burst of invalid transactions. In this case, we should make sure that valid transactions in the Mempool are not dropped nor affected

@fed-franz
Copy link
Contributor

Should we close this? @herr-seppia
We already ARE prioritizing txs based on higher-gas-price strategy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:p2p issues related to kadcast, peer, gossip mark:testnet
Projects
None yet
Development

No branches or pull requests

2 participants