Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mempool extraction by GasPrice #1330

Merged
merged 1 commit into from
Mar 7, 2022
Merged

Conversation

herr-seppia
Copy link
Member

@herr-seppia herr-seppia commented Mar 7, 2022

Fee() returns GasPrice instead of GasLimit
Fee() is used to RangeSort txs extraction

See also dusk-network/rusk#605
See also #1240

@codecov-commenter
Copy link

codecov-commenter commented Mar 7, 2022

Codecov Report

Merging #1330 (e98d625) into master (828364b) will decrease coverage by 8.63%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1330      +/-   ##
==========================================
- Coverage   50.51%   41.87%   -8.64%     
==========================================
  Files         145      144       -1     
  Lines        7544     9167    +1623     
==========================================
+ Hits         3811     3839      +28     
- Misses       3066     4744    +1678     
+ Partials      667      584      -83     
Impacted Files Coverage Δ
pkg/core/consensus/testing/node.go 0.00% <0.00%> (-93.55%) ⬇️
...ore/consensus/blockgenerator/candidate/testutil.go 0.00% <0.00%> (-90.91%) ⬇️
pkg/core/consensus/testing/utils.go 0.00% <0.00%> (-75.61%) ⬇️
...core/consensus/blockgenerator/candidate/genesis.go 0.00% <0.00%> (-69.24%) ⬇️
...nsensus/blockgenerator/candidate/blockgenerator.go 0.00% <0.00%> (-64.29%) ⬇️
pkg/gql/query/transactions.go 13.27% <0.00%> (-52.71%) ⬇️
pkg/rpc/client/session.go 21.42% <0.00%> (-47.15%) ⬇️
pkg/util/nativeutils/eventbus/eventbus.go 57.14% <0.00%> (-42.86%) ⬇️
pkg/rpc/client/client.go 3.73% <0.00%> (-36.61%) ⬇️
pkg/core/consensus/reduction/aggregator.go 56.25% <0.00%> (-35.06%) ⬇️
... and 165 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f41e93...e98d625. Read the comment docs.

- `Fee()` returns GasPrice instead of GasLimit
- `Fee()` is used to RangeSort txs extraction

See also dusk-network/rusk#605
See also #1240
@herr-seppia herr-seppia force-pushed the mempool-by-gasprice-1320 branch from 8d69106 to e98d625 Compare March 7, 2022 16:38
Copy link
Contributor

@goshawk-3 goshawk-3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@herr-seppia herr-seppia merged commit 2526c44 into master Mar 7, 2022
@herr-seppia herr-seppia deleted the mempool-by-gasprice-1320 branch March 7, 2022 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants