Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sortition Hash is not compliant with specification #1494

Open
fed-franz opened this issue Feb 6, 2023 · 2 comments
Open

Sortition Hash is not compliant with specification #1494

fed-franz opened this issue Feb 6, 2023 · 2 comments

Comments

@fed-franz
Copy link
Contributor

Description
createSortitionHash returns $H(round||iteration||step||seed)$, but the specification states it should be $H(seed||round||step||iteration)$.

Logically speaking, the concatenation order should follow round->step->iteration, like in the specification.
Technically speaking, this does not affect correctness/security, as long as all nodes calculate the same hash.

Solutions
There are two options:

  1. Leave the code unchanged and update the specifications accordingly
  2. Adapt the code to the specification
@fed-franz
Copy link
Contributor Author

IMHO, I strongly believe we should change the code.

@fed-franz
Copy link
Contributor Author

Mirrored Issue in rusk#907

@fed-franz fed-franz mentioned this issue Jun 2, 2023
Closed
@fed-franz fed-franz linked a pull request Jun 2, 2023 that will close this issue
Make sortition hash compliant with specification #1528
Closed
@fed-franz fed-franz mentioned this issue Aug 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make sortition hash compliant with specification dusk-network/dusk-blockchain
1 participant
@fed-franz