Make Sortition Hash compliant with specification #917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fed-franz
changed the title
|
IMHO, |
fed-franz
force-pushed
the
907-make-sortition-hash-compliant-with-specification
branch
2 times, most recently
from
6af2ffe to
83f51d3
Compare
herr-seppia
previously requested changes
Jun 2, 2023
herr-seppia
dismissed
their stale review
No more dusk-blockchain compatibility is required
|
@fed-franz I've dismissed my blocking review. Please go on if this is still required |
fed-franz
force-pushed
the
907-make-sortition-hash-compliant-with-specification
branch
from
83f51d3 to
5bcb3ec
Compare
|
Does this mean the mirror issue on |
fed-franz
force-pushed
the
907-make-sortition-hash-compliant-with-specification
branch
from
5bcb3ec to
6de3313
Compare
This changes the hash from H(round||counter||step||seed) to H(seed||round||step||counter), to be compliant with Deterministic Sortition specification. Tests 'test_sortition_hash()' and 'test_generate_sortition_score()' are also updated.
Fixed tests: - test_collect_votes - test_deterministic_sortition_1 - test_deterministic_sortition_2 test_collect_votes code has been simplified.
fed-franz
force-pushed
the
907-make-sortition-hash-compliant-with-specification
branch
from
6de3313 to
54c3aa4
Compare
fed-franz
deleted the
907-make-sortition-hash-compliant-with-specification
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #907
This PR changes the sortition hash from$H(round||counter||step||seed)$ to $H(seed||round||step||counter)$ ,
to be compliant with Deterministic Sortition specification.
The following tests are also updated:
test_sortition_hash,test_generate_sortition_score,test_collect_votes,test_deterministic_sortition_1,test_deterministic_sortition_2.Note that
test_collect_votescode has been also overhauled to make it simpler and easier to update in the future.