Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Sortition Hash compliant with specification #907

Closed
fed-franz opened this issue May 30, 2023 · 0 comments · Fixed by #917
Closed

Make Sortition Hash compliant with specification #907

fed-franz opened this issue May 30, 2023 · 0 comments · Fixed by #917
Labels
module:consensus Issues related to consensus module type:docs deliverable should be documentation

Comments

@fed-franz
Copy link
Contributor

fed-franz commented May 30, 2023 •
edited
Loading

Issue
create_sortition_hash() returns $H(round||counter||step||seed)$, but the specifications state it should be $H(seed||round||step||counter)$.

Solution
Change hashing order to the one in specifications
@fed-franz fed-franz added the type:docs deliverable should be documentation label May 30, 2023
@fed-franz fed-franz mentioned this issue May 30, 2023
Open
@fed-franz fed-franz changed the title Make Sortition compliant with specification Make Sortition Hasah compliant with specification Jun 1, 2023
@fed-franz fed-franz changed the title Make Sortition Hasah compliant with specification Make Sortition Hash compliant with specification Jun 1, 2023
@fed-franz fed-franz mentioned this issue Jun 1, 2023
Merged
@fed-franz fed-franz linked a pull request Jun 1, 2023 that will close this issue
Make Sortition Hash compliant with specification #917
Merged
@ZER0 ZER0 added the module:consensus Issues related to consensus module label Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
module:consensus Issues related to consensus module type:docs deliverable should be documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make Sortition Hash compliant with specification dusk-network/rusk
2 participants
@ZER0 @fed-franz