Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve mempool extraction #1422

Merged
merged 1 commit into from
Jun 20, 2022
Merged

Improve mempool extraction #1422

merged 1 commit into from
Jun 20, 2022

Conversation

herr-seppia
Copy link
Member

Resolves #1421

@herr-seppia herr-seppia self-assigned this Jun 20, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #1422 (1b1ef4c) into master (828364b) will decrease coverage by 9.47%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1422      +/-   ##
==========================================
- Coverage   50.51%   41.03%   -9.48%     
==========================================
  Files         145      144       -1     
  Lines        7544     9467    +1923     
==========================================
+ Hits         3811     3885      +74     
- Misses       3066     4950    +1884     
+ Partials      667      632      -35     
Impacted Files Coverage Δ
pkg/core/consensus/testing/node.go 0.00% <0.00%> (-93.55%) ⬇️
...ore/consensus/blockgenerator/candidate/testutil.go 0.00% <0.00%> (-90.91%) ⬇️
pkg/core/consensus/testing/utils.go 0.00% <0.00%> (-75.61%) ⬇️
...core/consensus/blockgenerator/candidate/genesis.go 0.00% <0.00%> (-69.24%) ⬇️
...nsensus/blockgenerator/candidate/blockgenerator.go 0.00% <0.00%> (-64.29%) ⬇️
pkg/gql/query/transactions.go 13.43% <0.00%> (-52.55%) ⬇️
pkg/rpc/client/session.go 21.42% <0.00%> (-47.15%) ⬇️
pkg/util/nativeutils/eventbus/eventbus.go 57.14% <0.00%> (-42.86%) ⬇️
pkg/rpc/client/client.go 3.73% <0.00%> (-36.61%) ⬇️
pkg/core/consensus/reduction/aggregator.go 56.25% <0.00%> (-35.06%) ⬇️
... and 166 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a78d05...1b1ef4c. Read the comment docs.

@herr-seppia herr-seppia marked this pull request as ready for review June 20, 2022 13:06
Copy link
Contributor

@t00ts t00ts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with couple nits.

pkg/core/mempool/mempool.go Show resolved Hide resolved
pkg/core/mempool/mempool.go Outdated Show resolved Hide resolved
@herr-seppia herr-seppia force-pushed the estimated-gas-mempool-1421 branch from 1b1ef4c to ac61db1 Compare June 20, 2022 15:21
@herr-seppia herr-seppia force-pushed the estimated-gas-mempool-1421 branch from ac61db1 to 9b31476 Compare June 20, 2022 18:27
@herr-seppia herr-seppia merged commit 1ad9da3 into master Jun 20, 2022
@herr-seppia herr-seppia deleted the estimated-gas-mempool-1421 branch June 20, 2022 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve mempool extraction
3 participants