-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add serde feature #141
Add serde feature #141
Conversation
85991d8
to
c575083
Compare
c575083
to
c94c9e9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM from my side, but I'm waiting for a second approval from a maintainer of this repository
4f06708
to
c40b897
Compare
c40b897
to
0e203e1
Compare
8eb2269
to
82aa88f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally, looks good to me. But based on the other two PRs (dusk-network/bls12_381-bls#22 & dusk-network/jubjub-schnorr#30), and for consistency, I would suggest having the tests as integration tests rather than module tests. Also because the current module tests are testing the implementation for Fr
, which is in another module.
Edit: After checking back, we can leave it as it is except for the tests for Fr
. Can you move them into the respective Dusk.rs file of the Fr module?
6ac3bb3
to
a8d99dc
Compare
6dc2c2a
to
d10ff66
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good to me, but please also update the issue and pr description and add an entry to the changelog
d10ff66
to
bddae14
Compare
bddae14
to
69cb8ac
Compare
69cb8ac
to
1f80e75
Compare
1f80e75
to
52e9c69
Compare
52e9c69
to
7c4a83a
Compare
7c4a83a
to
0592a2a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
We can now aim for a 0.14.2 release of this crate tomorrow, so that we can proceed directly with the phoenix-core crate that depends on it.
For dusk-network/rusk/issues/2773 and #143.
To serializeAffineNielsPoint
andExtendedNielsPoint
, I implementeddusk_bytes::Serializable
for them.But there is currently some uncertainty about the correctness of the approach used to serialize because I don't understand
AffinePoint
's serialization and I'm unsure about whether or not it will be relevant toAffineNielsPoint
andExtendedNielsPoint
.Edit:
AffineNielsPoint
andExtendedNielsPoint
have not being changed.