Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI improvements #40

Merged
merged 8 commits into from
Nov 16, 2023
Merged

CLI improvements #40

merged 8 commits into from
Nov 16, 2023

Conversation

xevisalle
Copy link
Member

No description provided.

@xevisalle xevisalle requested a review from miloszm November 14, 2023 16:24
Copy link
Collaborator

@miloszm miloszm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not clear to me how to run integration tests and where the config for integration tests is located. When I tried cargo t --release --features="int_tests", all tests were failing, and some strange folder named integration-tests.. was created. Seems like integration tests are not in a ready-to-use state.

@xevisalle
Copy link
Member Author

@miloszm you need to reintroduce the addresses of the node in config.toml. No idea why this happens...

@xevisalle xevisalle requested a review from miloszm November 15, 2023 15:21
Copy link
Collaborator

@miloszm miloszm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good but configs with no format and extension need to be redone

license-provider/tests/config/test_secret_key_lp Outdated Show resolved Hide resolved
license-provider/src/reference_lp.rs Outdated Show resolved Hide resolved
moat-cli-lp/src/main.rs Outdated Show resolved Hide resolved
@xevisalle xevisalle requested a review from miloszm November 16, 2023 14:14
config copy.toml Outdated Show resolved Hide resolved
integration-tests/Cargo.toml Outdated Show resolved Hide resolved
@xevisalle xevisalle requested a review from miloszm November 16, 2023 15:42
Copy link
Collaborator

@miloszm miloszm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xevisalle xevisalle merged commit 82b9a27 into main Nov 16, 2023
@xevisalle xevisalle deleted the api branch November 16, 2023 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants