Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved error handling #51

Merged
merged 4 commits into from
Nov 21, 2023
Merged

Improved error handling #51

merged 4 commits into from
Nov 21, 2023

Conversation

miloszm
Copy link
Collaborator

@miloszm miloszm commented Nov 21, 2023

Improved error handling, de-duplicated and refactored error type, enriched error conversions, changed return types of methods to propagate errors, removed unwraps.
This change appies to moat-code, CLIs, moat example and tests.
Implements issue #45

@miloszm miloszm requested a review from xevisalle November 21, 2023 14:53
Cargo.toml Show resolved Hide resolved
moat-example/src/main.rs Outdated Show resolved Hide resolved
@miloszm miloszm requested a review from xevisalle November 21, 2023 15:53
Copy link
Member

@xevisalle xevisalle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

moat-example/src/main.rs Outdated Show resolved Hide resolved
@miloszm miloszm merged commit 3e73a7d into main Nov 21, 2023
5 checks passed
@miloszm miloszm deleted the error-handing-refactor-45 branch November 21, 2023 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants