Merge pull request #228 from dusk-network/eq-impl

impl `Eq` for `TxSkeleton` and `StealthAddress`
dusk-network · Jul 7, 2024 · b3ee366 · b3ee366
2 parents f4a8109 + d6bf04c
commit b3ee366
Show file tree

Hide file tree

Showing 6 changed files with 10 additions and 11 deletions.
diff --git a/core/CHANGELOG.md b/core/CHANGELOG.md
@@ -7,6 +7,11 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+### Added
+
+- impl `Eq` for `StealthAddress`
+- impl `Eq` for `TxSkeleton`
+
 ## [0.30.0] - 2024-07-03
 
 ### Added

diff --git a/core/src/keys/public.rs b/core/src/keys/public.rs
@@ -16,7 +16,7 @@ use dusk_jubjub::GENERATOR_EXTENDED;
 use subtle::{Choice, ConstantTimeEq};
 
 /// Public pair of `a·G` and `b·G` defining a [`PublicKey`]
-#[derive(Debug, Clone, Copy)]
+#[derive(Debug, Clone, Copy, Eq)]
 #[cfg_attr(
     feature = "rkyv-impl",
     derive(Archive, Serialize, Deserialize),
@@ -72,8 +72,6 @@ impl PartialEq for PublicKey {
     }
 }
 
-impl Eq for PublicKey {}
-
 impl From<&SecretKey> for PublicKey {
     fn from(sk: &SecretKey) -> Self {
         let A = GENERATOR_EXTENDED * sk.a();

diff --git a/core/src/keys/view.rs b/core/src/keys/view.rs
@@ -19,7 +19,7 @@ use rkyv::{Archive, Deserialize, Serialize};
 ///
 /// The notes are encrypted against secret a, so this is used to decrypt the
 /// blinding factor and value
-#[derive(Clone, Copy, Debug)]
+#[derive(Clone, Copy, Debug, Eq)]
 #[cfg_attr(
     feature = "rkyv-impl",
     derive(Archive, Serialize, Deserialize),
@@ -43,8 +43,6 @@ impl PartialEq for ViewKey {
     }
 }
 
-impl Eq for ViewKey {}
-
 impl ViewKey {
     /// This method is used to construct a new `ViewKey` from the given
     /// pair of secret `a` and public `b·G`.

diff --git a/core/src/note.rs b/core/src/note.rs
@@ -66,7 +66,7 @@ impl TryFrom<i32> for NoteType {
 }
 
 /// A note that does not encrypt its value
-#[derive(Clone, Debug)]
+#[derive(Clone, Debug, Eq)]
 #[cfg_attr(
     feature = "rkyv-impl",
     derive(Archive, Serialize, Deserialize),
@@ -89,8 +89,6 @@ impl PartialEq for Note {
     }
 }
 
-impl Eq for Note {}
-
 impl Note {
     /// Creates a new phoenix output note
     pub fn new<R: RngCore + CryptoRng>(

diff --git a/core/src/stealth_address.rs b/core/src/stealth_address.rs
@@ -18,7 +18,7 @@ use rkyv::{Archive, Deserialize, Serialize};
 /// system.
 /// A `StealthAddress` is composed by a one-time note-public-key (the actual
 /// address) and a random point `R`.
-#[derive(Default, Debug, Clone, Copy)]
+#[derive(Default, Debug, Clone, Copy, Eq)]
 #[cfg_attr(
     feature = "rkyv-impl",
     derive(Archive, Serialize, Deserialize),

diff --git a/core/src/transaction.rs b/core/src/transaction.rs
@@ -19,7 +19,7 @@ use dusk_bytes::{DeserializableSlice, Error as BytesError, Serializable};
 use crate::{Note, OUTPUT_NOTES};
 
 /// A phoenix transaction, referred to as tx-skeleton in the specs.
-#[derive(Debug, Clone, PartialEq)]
+#[derive(Debug, Clone, PartialEq, Eq)]
 #[cfg_attr(
     feature = "rkyv-impl",
     derive(Archive, Serialize, Deserialize),